Skip to content

Commit ae1a64b

Browse files
author
Daan Hoogland
committed
co-pilot's comments addressed
1 parent d1067a6 commit ae1a64b

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2477,10 +2477,7 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
24772477

24782478
_executor = Executors.newScheduledThreadPool(wrks, new NamedThreadFactory("UserVm-Scavenger"));
24792479

2480-
String vmIpWorkers = configs.get(VmIpFetchTaskWorkers.value().toString());
2481-
int vmipwrks = NumbersUtil.parseInt(vmIpWorkers, 10);
2482-
2483-
_vmIpFetchExecutor = Executors.newScheduledThreadPool(vmipwrks, new NamedThreadFactory("UserVm-ipfetch"));
2480+
_vmIpFetchExecutor = Executors.newScheduledThreadPool(VmIpFetchTaskWorkers.value(), new NamedThreadFactory("UserVm-ipfetch"));
24842481

24852482
String aggregationRange = configs.get("usage.stats.job.aggregation.range");
24862483
int _usageAggregationRange = NumbersUtil.parseInt(aggregationRange, 1440);
@@ -3144,9 +3141,8 @@ private void generateNetworkUsageForVm(VirtualMachine vm, boolean isDisplay, Str
31443141
NetworkVO network = _networkDao.findById(nic.getNetworkId());
31453142
long isDefault = (nic.isDefaultNic()) ? 1 : 0;
31463143
UsageEventUtils.publishUsageEvent(eventType, vm.getAccountId(), vm.getDataCenterId(), vm.getId(),
3147-
Long.toString(nic.getId()), network.getNetworkOfferingId(), null, isDefault, vm.getClass().getName(), vm.getUuid(), true);
3144+
Long.toString(nic.getId()), network.getNetworkOfferingId(), null, isDefault, vm.getClass().getName(), vm.getUuid(), isDisplay);
31483145
}
3149-
31503146
}
31513147

31523148
@Override
@@ -3482,7 +3478,7 @@ public UserVm rebootVirtualMachine(RebootVMCmd cmd) throws InsufficientCapacityE
34823478
throw new InvalidParameterValueException("Booting into a hardware setup menu is not implemented on " + vmInstance.getHypervisorType());
34833479
}
34843480

3485-
UserVm userVm = rebootVirtualMachine(vmId, cmd.getBootIntoSetup(), cmd.isForced());
3481+
UserVm userVm = rebootVirtualMachine(vmId, enterSetup, cmd.isForced());
34863482
if (userVm != null ) {
34873483
// update the vmIdCountMap if the vm is in advanced shared network with out services
34883484
final List<NicVO> nics = _nicDao.listByVmId(vmId);

0 commit comments

Comments
 (0)