-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enable UEFI on KVM hosts (by default), and configure with some default settings #11740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.22
Are you sure you want to change the base?
Enable UEFI on KVM hosts (by default), and configure with some default settings #11740
Conversation
|
@blueorangutan package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enables UEFI support on KVM hosts by default with appropriate configuration settings across multiple system components.
- Adds UEFI configuration properties for legacy and secure boot modes with OVMF firmware paths
- Integrates UEFI properties files into system VM agents and console proxy components
- Updates packaging dependencies to include required OVMF and swtpm packages
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| agent/conf/uefi.properties.in | Defines UEFI configuration properties with template placeholders for firmware paths |
| packaging/el8/replace.properties | Sets OVMF firmware file paths for CentOS/RHEL 8 systems |
| packaging/debian/replace.properties | Sets OVMF firmware file paths for Debian-based systems |
| packaging/el8/cloud.spec | Adds edk2-ovmf and swtpm package dependencies for RPM builds |
| debian/control | Adds ovmf and swtpm package dependencies for Debian builds |
| pom.xml | Excludes uefi.properties from license header checks |
| systemvm/systemvm-agent-descriptor.xml | Includes uefi.properties in system VM agent configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #11740 +/- ##
======================================
Coverage 3.58% 3.58%
======================================
Files 445 445
Lines 37534 37534
Branches 6901 6901
======================================
Hits 1346 1346
Misses 36024 36024
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15193 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
checked the settings on ol8 and u24
|
Hey @sureshanaparti , I am having problem with Snapshots of Windows guest instances because they require UEFI. Apparently, Have you consider this condition? |
will check it @daviftorres |
b352909 to
ff29741
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15298 |
@daviftorres btw: the issue does not block this PR as this only changes the KVM host setting, not vm settings |
|
@sureshanaparti , ready to merge? |
not yet @DaanHoogland , will update you. |
ff29741 to
6847c0d
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15463 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
@DaanHoogland this is ready after smoke tests |
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15491 |
|
[SF] Trillian test result (tid-14704)
|
f3a46de to
4a752ad
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15528 |
|
@sureshanaparti |
@weizhouapache doc PR here: apache/cloudstack-documentation#589 |
4a752ad to
1090d3f
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15651 |
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |

Description
This PR enables UEFI on KVM hosts (by default), and configure with some default settings.
and updates the logs while listing host for migration of a UEFI enabled VM (fixes #11963).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Verified the UEFI packages and settings at /etc/cloudstack/agent/uefi.properties in ol8/ol9/debian12.
KVM Host / Agent (OL8):
MS (OL8):
KVM Host / Agent (Debian12):
MS (Debian12):
How did you try to break this feature and the system with this change?