Skip to content

Fix error message while creating local storage pool #12767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abh1sar merged 2 commits into from
Mar 27, 2026
Merged

Fix error message while creating local storage pool #12767

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96c9494
Fix error message while creating local storage pool
vishesh92 Mar 9, 2026
e9872b1
Address comments
vishesh92 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/src/main/java/com/cloud/storage/StorageManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,10 @@ public PrimaryDataStoreInfo createPool(CreateStoragePoolCmd cmd) throws Resource
if (Grouping.AllocationState.Disabled == zone.getAllocationState() && !_accountMgr.isRootAdmin(account.getId())) {
throw new PermissionDeniedException(String.format("Cannot perform this operation, Zone is currently disabled: %s", zone));
}
// Check if it's local storage and if it's enabled on the zone
if (isFileScheme && !zone.isLocalStorageEnabled()) {
throw new InvalidParameterValueException("Local storage is not enabled for zone: " + zone);
}
Comment thread
vishesh92 marked this conversation as resolved.
Outdated

managementService.checkJsInterpretationAllowedIfNeededForParameterValue(ApiConstants.IS_TAG_A_RULE,
Boolean.TRUE.equals(cmd.isTagARule()));
Expand Down
Loading