Skip to content

Add ROOT CAs to the trust store and allow force provisioning of certs hosts & systemVMs via ssh #12911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vishesh92 wants to merge 13 commits into
base: main
Choose a base branch
from

Address comments

5d8e797
Select commit
Loading
Failed to load commit list.
Refresh
Draft

Add ROOT CAs to the trust store and allow force provisioning of certs hosts & systemVMs via ssh #12911

Address comments
5d8e797
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 28, 2026 in 0s

18.03% (+0.00%) compared to e2c13da

View this Pull Request on Codecov

18.03% (+0.00%) compared to e2c13da

Details

Codecov Report

❌ Patch coverage is 36.46409% with 115 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.03%. Comparing base (e2c13da) to head (5d8e797).

Files with missing lines Patch % Lines
...n/java/org/apache/cloudstack/ca/CAManagerImpl.java 41.73% 57 Missing and 10 partials ⚠️
.../apache/cloudstack/ca/provider/RootCAProvider.java 13.63% 37 Missing and 1 partial ⚠️
.../api/command/admin/ca/ProvisionCertificateCmd.java 0.00% 4 Missing ⚠️
.../cloudstack/mom/webhook/WebhookDeliveryThread.java 0.00% 3 Missing ⚠️
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java 0.00% 1 Missing ⚠️
utils/src/main/java/com/cloud/utils/nio/Link.java 0.00% 1 Missing ⚠️
...rg/apache/cloudstack/utils/security/CertUtils.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               main   #12911    +/-   ##
==========================================
  Coverage     18.02%   18.03%            
- Complexity    16620    16631    +11     
==========================================
  Files          6029     6029            
  Lines        542181   542310   +129     
  Branches      66450    66476    +26     
==========================================
+ Hits          97737    97804    +67     
- Misses       433428   433476    +48     
- Partials      11016    11030    +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov