Fix PMD violations

Author: reta

core/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java

@@ -85,6 +85,8 @@ public String run() {
         return Boolean.parseBoolean(cname);
     }
 
+    
+    @SuppressWarnings("PMD.UselessPureMethodCall")
     public static void doHacks() {
         if (skipHack("org.apache.cxf.JDKBugHacks.all")) {
             return;

core/src/main/java/org/apache/cxf/common/logging/LogUtils.java

@@ -226,6 +226,7 @@ public static Logger getL7dLogger(Class<?> cls,
     /**
      * Create a logger
      */
+    @SuppressWarnings("PMD.UselessPureMethodCall")
     protected static Logger createLogger(Class<?> cls,
                                          String name,
                                          String loggerName) {

core/src/main/java/org/apache/cxf/configuration/spring/ConfigurerImpl.java

@@ -61,6 +61,7 @@ public class ConfigurerImpl extends BeanConfigurerSupport
     private final Map<String, List<MatcherHolder>> wildCardBeanDefinitions = new TreeMap<>();
     private BeanFactory beanFactory;
 
+    @SuppressWarnings("PMD.OverrideBothEqualsAndHashCodeOnComparable")
     static class MatcherHolder implements Comparable<MatcherHolder> {
         Matcher matcher;
         String wildCardId;

core/src/main/java/org/apache/cxf/workqueue/AutomaticWorkQueueImpl.java

@@ -49,6 +49,7 @@
 import org.apache.cxf.common.util.ReflectionUtil;
 
 @NoJSR250Annotations
+@SuppressWarnings("PMD.OverrideBothEqualsAndHashCodeOnComparable")
 public class AutomaticWorkQueueImpl implements AutomaticWorkQueue {
     public static final String PROPERTY_NAME = "name";
     static final int DEFAULT_MAX_QUEUE_SIZE = 256;

core/src/test/java/org/apache/cxf/attachment/AttachmentDeserializerTest.java

@@ -55,8 +55,8 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
 
 public class AttachmentDeserializerTest {
 
@@ -696,12 +696,8 @@ public void testManyAttachments() throws Exception {
         ad.initializeAttachments();
 
         // Force it to load the attachments
-        try {
-            msg.getAttachments().size();
-            fail("Failure expected on too many attachments");
-        } catch (RuntimeException ex) {
-            // expected
-        }
+        assertThrows("Failure expected on too many attachments", RuntimeException.class, 
+            () -> msg.getAttachments().size());
     }
 
     @Test
@@ -734,12 +730,8 @@ public void testChangingMaxAttachmentCount() throws Exception {
         ad.initializeAttachments();
 
         // Force it to load the attachments
-        try {
-            msg.getAttachments().size();
-            fail("Failure expected on too many attachments");
-        } catch (RuntimeException ex) {
-            // expected
-        }
+        assertThrows("Failure expected on too many attachments", RuntimeException.class,
+            () -> msg.getAttachments().size());
 
         // Now we'll allow it
         msg = new MessageImpl();

integration/spring-boot/autoconfigure/src/test/java/org/apache/cxf/spring/boot/autoconfigure/micrometer/provider/SpringBasedTimedAnnotationProviderTest.java

@@ -54,6 +54,7 @@ public class SpringBasedTimedAnnotationProviderTest {
     private MethodDispatcher methodDispatcher;
 
     @Before
+    @SuppressWarnings("PMD.UselessPureMethodCall")
     public void setUp() {
         openMocks(this);
         underTest = new SpringBasedTimedAnnotationProvider();

rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/array/DuplicateArrayReturnItem.java

@@ -19,6 +19,7 @@
 
 package org.apache.cxf.aegis.type.array;
 
+@SuppressWarnings("PMD.OverrideBothEqualsAndHashCodeOnComparable")
 public class DuplicateArrayReturnItem implements Comparable<Object> {
 
     String name;

rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBContextInitializer.java

@@ -83,6 +83,7 @@ class JAXBContextInitializer extends ServiceModelVisitor {
     }
 
     @Override
+    @SuppressWarnings("PMD.UselessPureMethodCall")
     public void begin(MessagePartInfo part) {
         Class<?> clazz = part.getTypeClass();
         if (clazz == null) {

rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultExceptionClassProviderTest.java

@@ -34,6 +34,7 @@
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.MockitoAnnotations.openMocks;
 
+@SuppressWarnings("PMD.UselessPureMethodCall")
 public class DefaultExceptionClassProviderTest {
 
     private static final Exception EXCEPTION_CAUSE = new CauseException();

rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultTimedAnnotationProviderTest.java

@@ -42,7 +42,7 @@
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.MockitoAnnotations.openMocks;
 
-@SuppressWarnings({"unused"})
+@SuppressWarnings({"unused", "PMD.UselessPureMethodCall"})
 public class DefaultTimedAnnotationProviderTest {
 
     private DefaultTimedAnnotationProvider underTest;