Skip to content

Incorrect null handling in fast shuffle encoder #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andygrove opened this issue Mar 12, 2025 · 2 comments · Fixed by #1522
Closed

Incorrect null handling in fast shuffle encoder #1520

andygrove opened this issue Mar 12, 2025 · 2 comments · Fixed by #1522
Labels
bug Something isn't working
Milestone
0.8.0

Comments

@andygrove
Copy link
Member

Describe the bug

According to #1511 (comment) there is a bug in the fast encoder.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
@andygrove andygrove added the bug Something isn't working label Mar 12, 2025
@andygrove andygrove added this to the 0.7.0 milestone Mar 12, 2025
@Kontinuation Kontinuation mentioned this issue Mar 13, 2025
Merged
@Kontinuation
Copy link
Member

Kontinuation commented Mar 13, 2025 •
edited
Loading

This problem was deliberately left unfixed according to #1190 (comment), but it may cause problems as we make future changes to the shuffle writer (until we finally drop fast-encoding and switch to arrow-ipc). I've submitted a patch to fix it: #1522

@andygrove andygrove modified the milestones: 0.7.0, 0.8.0 Mar 13, 2025
@andygrove
Copy link
Member Author

Thanks @Kontinuation. Moving this to 0.8.0 since it is not a blocker for 0.7.0 (we are hoping to cut release candidate soon, maybe today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
2 participants
@andygrove @Kontinuation