Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-][Master] Add Continue_Other_Task_Chain FailureStrategy #16912

Open
2 tasks done
topsli opened this issue Dec 23, 2024 · 5 comments
Open
2 tasks done

[DSIP-][Master] Add Continue_Other_Task_Chain FailureStrategy #16912

topsli opened this issue Dec 23, 2024 · 5 comments

Comments

@topsli
Copy link
Contributor

topsli commented Dec 23, 2024

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

Currently, the list of FailureStrategy only have END and CONTINUE. May be it should have another choice: Continue_Other_Task_Chain

/**
* 0 ending process when some tasks failed.
* 1 continue running when some tasks failed.
* 2 one task failed will continue other running task chain.
**/
END(0, "end"),
CONTINUE(1, "continue"),
Continue_Other_Task_Chain(2,"One task failed will continue other running task chain");

Design Detail

No response

Compatibility, Deprecation, and Migration Plan

No response

Test Plan

No response

Code of Conduct

@topsli topsli added DSIP Waiting for reply Waiting for reply labels Dec 23, 2024
@ruanwenjun
Copy link
Member

What is OTHER_CONTINUE , please add detail design and specific motivation.

@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Dec 24, 2024
@SbloodyS SbloodyS changed the title [DSIP-88][Master] Add Other_Continue FailureStrategy [DSIP-][Master] Add Other_Continue FailureStrategy Dec 24, 2024
@topsli
Copy link
Contributor Author

topsli commented Dec 25, 2024

For example, a workflow process which have three branches like A,B,C. If branch B have a task failed, only affects the branch B. The other branch can continue to running.
1735091800531_3F1ABDBD-7137-4ea8-8054-BE3BBA8A5876
1735091773503_345302E8-292B-425b-892B-A5E3F8B83F01

@topsli
Copy link
Contributor Author

topsli commented Dec 25, 2024

The status of the workflow instance also is failed.
1735092189761_A8ED0534-1E0E-42a1-8516-8A7134029AC8

@ruanwenjun
Copy link
Member

The current naming of our strategies is confusing
It's better to have a more intuitive name
e.g.

Continue_Other_Task("One task failed will continue other running task")
Continue_Other_Task_Chain("One task failed will continue other  running task chain")
Kill_Other_Task_Chain("One task failed will kill other running task chain")

Continue and OTHER_CONTINUE will make confuse.

@topsli
Copy link
Contributor Author

topsli commented Dec 25, 2024

Continue_Other_Task_Chain("One task failed will continue other running task chain").
I think this one(Continue_Other_Task_Chain)is the best description.

@topsli topsli changed the title [DSIP-][Master] Add Other_Continue FailureStrategy [DSIP-][Master] Add Continue_Other_Task_Chain FailureStrategy Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants