Skip to content

[Bug] FilteredRules::filterValidRules will not filter any rule #55718

@flashzxi

Description

@flashzxi

Search before asking

  • I had searched in the issues and found no similar issues.

Version

master branch

What's Wrong?

    @Override
    public List<Rule> filterValidRules(CascadesContext cascadesContext) {
        BitSet disableRules = cascadesContext.getAndCacheDisableRules();
        if (disableRules.isEmpty()) {
            return allRules;
        }
        List<Rule> validRules = new ArrayList<>(allRules); // this should be List<Rule> validRules = new ArrayList<>()
        for (Rule rule : allRules) {
            if (!disableRules.get(rule.getRuleType().type())) {
                validRules.add(rule);
            }
        }
        return validRules;
    }

validRules will contains repeat data, and filter nothing

What You Expected?

fix this bug

How to Reproduce?

No response

Anything Else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions