-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Open
Description
Search before asking
- I had searched in the issues and found no similar issues.
Version
master branch
What's Wrong?
@Override
public List<Rule> filterValidRules(CascadesContext cascadesContext) {
BitSet disableRules = cascadesContext.getAndCacheDisableRules();
if (disableRules.isEmpty()) {
return allRules;
}
List<Rule> validRules = new ArrayList<>(allRules); // this should be List<Rule> validRules = new ArrayList<>()
for (Rule rule : allRules) {
if (!disableRules.get(rule.getRuleType().type())) {
validRules.add(rule);
}
}
return validRules;
}
validRules will contains repeat data, and filter nothing
What You Expected?
fix this bug
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
No labels