Skip to content

Conversation

@zclllyybb
Copy link
Contributor

Reverts #57381

@Thearas
Copy link
Contributor

Thearas commented Nov 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 190301 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95d593edc891f234403c9ac2b9e673f7bd2f3348, data reload: false

query1	1034	431	404	404
query2	6570	1743	1707	1707
query3	6756	225	227	225
query4	26478	23458	23003	23003
query5	4480	641	478	478
query6	339	244	232	232
query7	4677	492	301	301
query8	312	263	258	258
query9	8725	2604	2614	2604
query10	524	350	292	292
query11	15774	15187	14920	14920
query12	194	121	115	115
query13	1692	574	449	449
query14	11915	9362	9450	9362
query15	208	198	182	182
query16	7709	704	538	538
query17	1426	804	638	638
query18	2070	491	359	359
query19	258	221	222	221
query20	147	141	139	139
query21	222	136	118	118
query22	4812	4710	4608	4608
query23	34769	34006	34149	34006
query24	8420	2569	2559	2559
query25	621	518	490	490
query26	1283	330	173	173
query27	2827	522	364	364
query28	5356	2277	2218	2218
query29	815	675	524	524
query30	320	236	223	223
query31	978	867	763	763
query32	84	71	73	71
query33	1218	394	342	342
query34	905	885	533	533
query35	875	830	762	762
query36	1013	1093	973	973
query37	129	119	90	90
query38	3624	3524	3494	3494
query39	1500	1409	1459	1409
query40	222	128	117	117
query41	58	56	56	56
query42	121	109	106	106
query43	491	499	465	465
query44	1217	739	742	739
query45	185	179	172	172
query46	891	991	632	632
query47	1744	1815	1707	1707
query48	412	433	342	342
query49	766	502	426	426
query50	642	717	399	399
query51	3963	3921	3869	3869
query52	108	105	100	100
query53	231	263	200	200
query54	308	306	281	281
query55	85	85	83	83
query56	319	317	301	301
query57	1165	1175	1098	1098
query58	301	271	267	267
query59	2623	2650	2603	2603
query60	364	342	333	333
query61	159	159	165	159
query62	825	732	653	653
query63	231	193	191	191
query64	4430	1178	884	884
query65	4040	3961	3946	3946
query66	1094	447	337	337
query67	15370	15247	15169	15169
query68	8422	888	596	596
query69	495	327	288	288
query70	1310	1271	1332	1271
query71	508	340	314	314
query72	6021	5039	5087	5039
query73	680	643	361	361
query74	9125	9240	8745	8745
query75	4119	3368	2833	2833
query76	3832	1154	747	747
query77	789	407	325	325
query78	9605	9634	8966	8966
query79	2366	806	590	590
query80	675	549	497	497
query81	486	271	231	231
query82	424	155	133	133
query83	304	267	254	254
query84	297	115	95	95
query85	953	503	435	435
query86	352	305	307	305
query87	3803	3718	3643	3643
query88	3253	2221	2218	2218
query89	408	327	286	286
query90	1999	230	216	216
query91	163	163	132	132
query92	86	66	64	64
query93	1407	988	641	641
query94	693	456	336	336
query95	415	318	301	301
query96	484	571	276	276
query97	2948	2976	2885	2885
query98	239	214	209	209
query99	1459	1407	1287	1287
Total cold run time: 281544 ms
Total hot run time: 190301 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95d593edc891f234403c9ac2b9e673f7bd2f3348, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.09	0.08
query4	1.61	0.12	0.12
query5	0.28	0.26	0.25
query6	1.18	0.65	0.64
query7	0.03	0.02	0.03
query8	0.06	0.04	0.05
query9	0.60	0.52	0.50
query10	0.59	0.59	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.61	0.62
query14	1.02	1.00	1.02
query15	0.85	0.84	0.83
query16	0.41	0.39	0.41
query17	1.02	0.99	1.02
query18	0.21	0.20	0.20
query19	1.86	1.77	1.80
query20	0.02	0.02	0.01
query21	15.45	0.17	0.14
query22	5.21	0.08	0.05
query23	15.67	0.25	0.10
query24	3.04	1.24	0.77
query25	0.07	0.06	0.05
query26	0.14	0.14	0.13
query27	0.06	0.06	0.05
query28	5.06	1.15	0.95
query29	12.66	3.95	3.19
query30	0.29	0.14	0.12
query31	2.81	0.60	0.38
query32	3.24	0.56	0.48
query33	3.08	3.01	3.04
query34	15.87	5.15	4.59
query35	4.56	4.55	4.57
query36	0.67	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.14	0.13
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 99.5 s
Total hot run time: 27.77 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 90.00% (18/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.72% (18056/34249)
Line Coverage 38.01% (164147/431856)
Region Coverage 32.34% (125124/386894)
Branch Coverage 33.77% (54763/162186)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 90.00% (18/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.48% (24067/33668)
Line Coverage 57.90% (250477/432601)
Region Coverage 52.97% (207886/392490)
Branch Coverage 54.69% (89312/163295)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

PR approved by anyone and no changes requested.

@zclllyybb zclllyybb merged commit 1770612 into master Nov 4, 2025
29 of 32 checks passed
@zclllyybb zclllyybb deleted the revert-57381-rename_stringview branch November 4, 2025 02:29
yiguolei pushed a commit that referenced this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants