From c9d47a31dadc16ad053bd7c8a65d894101b03371 Mon Sep 17 00:00:00 2001
From: Archit Singh Chauhan <88979004+archit-8@users.noreply.github.com>
Date: Tue, 16 Jan 2024 23:56:02 +0530
Subject: [PATCH 1/3] [ ISSUE #4733]printStackTrace() with log.error()

 Replace e.printStackTrace() to log.error()
---
 .../org/apache/eventmesh/runtime/client/impl/PubClientImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
index 734ad6fc54..df01ede809 100644
--- a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
+++ b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
@@ -73,7 +73,7 @@ public void close() {
             task.cancel(false);
             super.close();
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error("An error occurred during close(): {}", e.getMessage(), e);
         }
     }
 

From d2ae661b905e3522b16d387559e32ee00334b2b2 Mon Sep 17 00:00:00 2001
From: Archit Singh Chauhan <88979004+archit-8@users.noreply.github.com>
Date: Wed, 17 Jan 2024 00:02:34 +0530
Subject: [PATCH 2/3] [ ISSUE #4733 ]Substitute e.printStackTrace() with
 log.error()

e.printStackTrace() reomved
---
 .../main/java/org/apache/eventmesh/openconnect/SourceWorker.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java b/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
index bf9878e486..26c46f7c47 100644
--- a/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
+++ b/eventmesh-openconnect/eventmesh-openconnect-java/src/main/java/org/apache/eventmesh/openconnect/SourceWorker.java
@@ -276,7 +276,6 @@ public void stop() {
         try {
             source.stop();
         } catch (Exception e) {
-            e.printStackTrace();
             log.error("source destroy error", e);
         }
         log.info("pollService stopping");

From e86468f1ac276bebbdc76c1e276c03ddca88aa3f Mon Sep 17 00:00:00 2001
From: Archit Singh Chauhan <88979004+archit-8@users.noreply.github.com>
Date: Wed, 17 Jan 2024 00:10:29 +0530
Subject: [PATCH 3/3]  [ISSUE #4733] e.printStackTrace() with log.error()

Replaced e.printStackTrace with log.error()
---
 .../java/org/apache/eventmesh/common/ThreadWrapperTest.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eventmesh-common/src/test/java/org/apache/eventmesh/common/ThreadWrapperTest.java b/eventmesh-common/src/test/java/org/apache/eventmesh/common/ThreadWrapperTest.java
index 6315911eb8..9a29a7e998 100644
--- a/eventmesh-common/src/test/java/org/apache/eventmesh/common/ThreadWrapperTest.java
+++ b/eventmesh-common/src/test/java/org/apache/eventmesh/common/ThreadWrapperTest.java
@@ -74,7 +74,7 @@ public void run() {
                 try {
                     TimeUnit.MILLISECONDS.sleep(500);
                 } catch (InterruptedException e) {
-                    e.printStackTrace();
+                     log.error("Error occurred during sleep", e);
                 }
                 counter.set(100);
             }
@@ -136,4 +136,4 @@ public void run() {
         wrapper.setDaemon(daemon);
         return wrapper;
     }
-}
\ No newline at end of file
+}