Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] FuryCpp needs to add the benchmark module #2022

Closed
pandalee99 opened this issue Jan 24, 2025 · 0 comments · Fixed by #2028
Closed

[C++] FuryCpp needs to add the benchmark module #2022

pandalee99 opened this issue Jan 24, 2025 · 0 comments · Fixed by #2028
Assignees
@pandalee99
Labels
c++ enhancement New feature or request

Comments

@pandalee99
Copy link
Contributor

Feature Request

The lack of a benchmark module in FuryCpp leads to inaccurate performance testing.

This feature needs to be added to make the project more complete.

Is your feature request related to a problem? Please describe

relate #2013

Describe the solution you'd like

I tried to do some things, such as extracting benchmark.cc, but it could have been further isolated.

Describe alternatives you've considered

No response

Additional context

No response
@pandalee99 pandalee99 self-assigned this Jan 24, 2025
@pandalee99 pandalee99 added enhancement New feature or request c++ labels Jan 24, 2025
@pandalee99 pandalee99 mentioned this issue Jan 24, 2025
Merged
2 tasks
chaokunyang pushed a commit that referenced this issue Jan 25, 2025
@pandalee99
feat(c++): Add benchmark for performance evaluation (#2023)
a5f7e74 
<!--
**Thanks for contributing to Fury.**

**If this is your first time opening a PR on fury, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**

Contribution Checklist

- The **Apache Fury (incubating)** community has restrictions on the
naming of pr titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).

- Fury has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->

## What does this PR do?
In the process of project function improvement, if there is no
appropriate benchmark to test, it is difficult to judge the quality of
this new function.

Now, I decided to add a new benchmark to enhance FuryCpp

<img width="445" alt="image"
src="https://github.com/user-attachments/assets/c496bc6f-ca43-437e-961a-ba8a8c71b027"
/>


This is a preliminary plan. Do you have any better suggestions for using
benchmark.cc?

Then, on the use of `simd` to enhance FuryCpp, I will implement in the
next `pr`.

<!-- Describe the purpose of this PR. -->

## Related issues

relate #2022 

<!--
Is there any related issue? Please attach here.

- #xxxx0
- #xxxx1
- #xxxx2
-->

## Does this PR introduce any user-facing change?

<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?

## Benchmark
google/benchmark
version v1.9.1

<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
@pandalee99 pandalee99 mentioned this issue Jan 27, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pandalee99 pandalee99

Labels
c++ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(c++): BenchMark will be a Module pandalee99/fury
1 participant
@pandalee99