Checstyle errors

Author: haridsv

hbase-server/src/test/java/org/apache/hadoop/hbase/keymeta/TestManagedKeymeta.java

@@ -122,43 +122,47 @@ public void testEnableKeyManagementWithExceptionOnGetManagedKey() throws Excepti
 
   @Test
   public void testEnableKeyManagementWithClientSideServiceException() throws Exception {
-    doTestWithClientSideServiceException((mockStub, networkError) -> {
-      try {
-        when(mockStub.enableKeyManagement(any(), any())).thenThrow(networkError);
-      } catch (ServiceException e) {
-        // We are just setting up the mock, so no exception is expected here.
-        throw new RuntimeException("Unexpected ServiceException", e);
-      }
-      return null;
-    }, (client) -> {
-      try {
-        client.enableKeyManagement("cust", "namespace");
-      } catch (IOException e) {
-        throw new RuntimeException(e);
-      }
-      return null;
-    });
+    doTestWithClientSideServiceException(
+      (mockStub, networkError) -> {
+        try {
+          when(mockStub.enableKeyManagement(any(), any())).thenThrow(networkError);
+        } catch (ServiceException e) {
+          // We are just setting up the mock, so no exception is expected here.
+          throw new RuntimeException("Unexpected ServiceException", e);
+        }
+        return null;
+      },
+      (client) -> {
+        try {
+          client.enableKeyManagement("cust", "namespace");
+        } catch (IOException e) {
+          throw new RuntimeException(e);
+        }
+        return null;
+      });
   }
 
   @Test
   public void testGetManagedKeysWithClientSideServiceException() throws Exception {
     // Similar test for getManagedKeys method
-    doTestWithClientSideServiceException((mockStub, networkError) -> {
-      try {
-        when(mockStub.getManagedKeys(any(), any())).thenThrow(networkError);
-      } catch (ServiceException e) {
-        // We are just setting up the mock, so no exception is expected here.
-        throw new RuntimeException("Unexpected ServiceException", e);
-      }
-      return null;
-    }, (client) -> {
-      try {
-        client.getManagedKeys("cust", "namespace");
-      } catch (IOException | KeyException e) {
-        throw new RuntimeException(e);
-      }
-      return null;
-    });
+    doTestWithClientSideServiceException(
+      (mockStub, networkError) -> {
+        try {
+          when(mockStub.getManagedKeys(any(), any())).thenThrow(networkError);
+        } catch (ServiceException e) {
+          // We are just setting up the mock, so no exception is expected here.
+          throw new RuntimeException("Unexpected ServiceException", e);
+        }
+        return null;
+      },
+      (client) -> {
+        try {
+          client.getManagedKeys("cust", "namespace");
+        } catch (IOException | KeyException e) {
+          throw new RuntimeException(e);
+        }
+        return null;
+      });
   }
 
   @Test
@@ -213,22 +217,24 @@ public void testRotateSTKWithExceptionOnGetSystemKey() throws Exception {
 
   @Test
   public void testRotateSTKWithClientSideServiceException() throws Exception {
-    doTestWithClientSideServiceException((mockStub, networkError) -> {
-      try {
-        when(mockStub.rotateSTK(any(), any())).thenThrow(networkError);
-      } catch (ServiceException e) {
-        // We are just setting up the mock, so no exception is expected here.
-        throw new RuntimeException("Unexpected ServiceException", e);
-      }
-      return null;
-    }, (client) -> {
-      try {
-        client.rotateSTK();
-      } catch (IOException e) {
-        throw new RuntimeException(e);
-      }
-      return null;
-    });
+    doTestWithClientSideServiceException(
+      (mockStub, networkError) -> {
+        try {
+          when(mockStub.rotateSTK(any(), any())).thenThrow(networkError);
+        } catch (ServiceException e) {
+          // We are just setting up the mock, so no exception is expected here.
+          throw new RuntimeException("Unexpected ServiceException", e);
+        }
+        return null;
+      },
+      (client) -> {
+        try {
+          client.rotateSTK();
+        } catch (IOException e) {
+          throw new RuntimeException(e);
+        }
+        return null;
+      });
   }
 
   private void

hbase-shell/src/test/java/org/apache/hadoop/hbase/client/TestKeymetaMockProviderShell.java

@@ -38,9 +38,10 @@ public class TestKeymetaMockProviderShell extends ManagedKeyTestBase implements
   private final ScriptingContainer jruby = new ScriptingContainer();
 
   @Before
+  @Override
   public void setUp() throws Exception {
-    final Configuration conf = TEST_UTIL.getConfiguration();
     // Enable to be able to debug without timing out.
+    // final Configuration conf = TEST_UTIL.getConfiguration();
     // conf.set("zookeeper.session.timeout", "6000000");
     // conf.set("hbase.rpc.timeout", "6000000");
     // conf.set("hbase.rpc.read.timeout", "6000000");