HBASE-29662 - Avoid regionDir/tableDir creation as part of .regioninfo file creation in HRegion initialize

Author: Prathyusha Garre

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java

@@ -764,7 +764,7 @@ private static void writeRegionInfoFileContent(final Configuration conf, final F
     // First check to get the permissions
     FsPermission perms = CommonFSUtils.getFilePermissions(fs, conf, HConstants.DATA_FILE_UMASK_KEY);
     // Write the RegionInfo file content
-    try (FSDataOutputStream out = FSUtils.create(conf, fs, regionInfoFile, perms, null)) {
+    try (FSDataOutputStream out = FSUtils.create(conf, fs, regionInfoFile, perms, null, false)) {
       out.write(content);
     }
   }

hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java

@@ -212,14 +212,44 @@ public static boolean deleteRegionDir(final Configuration conf, final RegionInfo
    */
   public static FSDataOutputStream create(Configuration conf, FileSystem fs, Path path,
     FsPermission perm, InetSocketAddress[] favoredNodes) throws IOException {
+    return create(conf, fs, path, perm, favoredNodes, true);
+  }
+
+  /**
+   * Create the specified file on the filesystem. By default, this will:
+   * <ol>
+   * <li>overwrite the file if it exists</li>
+   * <li>apply the umask in the configuration (if it is enabled)</li>
+   * <li>use the fs configured buffer size (or 4096 if not set)</li>
+   * <li>use the configured column family replication or default replication if
+   * {@link ColumnFamilyDescriptorBuilder#DEFAULT_DFS_REPLICATION}</li>
+   * <li>use the default block size</li>
+   * <li>not track progress</li>
+   * </ol>
+   * @param conf            configurations
+   * @param fs              {@link FileSystem} on which to write the file
+   * @param path            {@link Path} to the file to write
+   * @param perm            permissions
+   * @param favoredNodes    favored data nodes
+   * @param isRecursiveCreate recursively create parent directories
+   * @return output stream to the created file
+   * @throws IOException if the file cannot be created
+   */
+  public static FSDataOutputStream create(Configuration conf, FileSystem fs, Path path,
+    FsPermission perm, InetSocketAddress[] favoredNodes, boolean isRecursiveCreate)
+    throws IOException {
     if (fs instanceof HFileSystem) {
       FileSystem backingFs = ((HFileSystem) fs).getBackingFs();
       if (backingFs instanceof DistributedFileSystem) {
         short replication = Short.parseShort(conf.get(ColumnFamilyDescriptorBuilder.DFS_REPLICATION,
           String.valueOf(ColumnFamilyDescriptorBuilder.DEFAULT_DFS_REPLICATION)));
-        DistributedFileSystem.HdfsDataOutputStreamBuilder builder =
-          ((DistributedFileSystem) backingFs).createFile(path).recursive().permission(perm)
-            .create();
+        DistributedFileSystem.HdfsDataOutputStreamBuilder builder = null;
+        if (isRecursiveCreate) {
+          builder = ((DistributedFileSystem) backingFs).createFile(path).recursive()
+            .permission(perm).create();
+        } else {
+          builder = ((DistributedFileSystem) backingFs).createFile(path).permission(perm).create();
+        }
         if (favoredNodes != null) {
           builder.favoredNodes(favoredNodes);
         }