Skip to content

Commit 0c60c10

Browse files
ZENOTMEZENOTME
and
ZENOTME
authored
fix: speficy the version of munge for msrv check (#987)
#704 fail in msrv check and I find that's because `cargo update faststr` will update the munge to `0.4.2` instead of `0.4.1`. The simple fix way is to specify the precise version of munge. But I'm not sure whether it's good practice here. Do you have any suggestions for this? cc @Xuanwo @xxchan Co-authored-by: ZENOTME <[email protected]>
1 parent 1a2a8c8 commit 0c60c10

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,8 @@ jobs:
152152
# Some dependencies don't correctly specify a minimal version for their dependencies and will fail to build.
153153
# So we update these transitive dependencies here.
154154
cargo update tap faststr metainfo linkedbytes
155+
# munge 0.4.2 will cause fail to use 1.7.1 so specify the correct version here.
156+
cargo update -p munge --precise 0.4.1
155157
- name: Setup MSRV Rust toolchain
156158
uses: ./.github/actions/setup-builder
157159
with:

0 commit comments

Comments
 (0)