From 48f9e3e8bff0224569da8dd5beb89ed0c8cc4513 Mon Sep 17 00:00:00 2001 From: Vipul Vaibhaw Date: Tue, 9 Jul 2024 07:37:24 +0530 Subject: [PATCH] feat: Add cargo machete (#448) * adding cargo machete to check unused dependencies * remove default values * adding a tag version instead of main * running cargo machete natively * removing unused dependency urlencoding * bug fixes --- .github/workflows/ci.yml | 3 +++ Cargo.toml | 1 - Makefile | 4 ++++ crates/catalog/rest/Cargo.toml | 1 - 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 536089fce..09f231735 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,6 +50,9 @@ jobs: - name: Cargo sort run: make cargo-sort + - name: Cargo Machete + run: make cargo-machete + build: runs-on: ${{ matrix.os }} strategy: diff --git a/Cargo.toml b/Cargo.toml index c3c99860a..db441ca08 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -84,7 +84,6 @@ tempfile = "3.8" tokio = { version = "1", default-features = false } typed-builder = "^0.18" url = "2" -urlencoding = "2" uuid = "1.6.1" volo-thrift = "0.10" hive_metastore = "0.1.0" diff --git a/Makefile b/Makefile index ff01e1807..abee425d7 100644 --- a/Makefile +++ b/Makefile @@ -32,6 +32,10 @@ cargo-sort: cargo install cargo-sort cargo sort -c -w +cargo-machete: + cargo install cargo-machete + cargo machete + fix-toml: cargo install taplo-cli --locked taplo fmt diff --git a/crates/catalog/rest/Cargo.toml b/crates/catalog/rest/Cargo.toml index 649234031..07943b884 100644 --- a/crates/catalog/rest/Cargo.toml +++ b/crates/catalog/rest/Cargo.toml @@ -42,7 +42,6 @@ serde_derive = { workspace = true } serde_json = { workspace = true } tokio = { workspace = true, features = ["sync"] } typed-builder = { workspace = true } -urlencoding = { workspace = true } uuid = { workspace = true, features = ["v4"] } [dev-dependencies]