Address comments from #822

Author: rshkv

crates/iceberg/src/lib.rs

@@ -73,7 +73,7 @@ mod avro;
 pub mod io;
 pub mod spec;
 
-pub mod metadata_scan;
+pub mod metadata_table;
 pub mod scan;
 
 pub mod expr;

crates/iceberg/src/metadata_scan.rs renamed to crates/iceberg/src/metadata_table.rs

@@ -36,11 +36,11 @@ use crate::Result;
 /// - <https://iceberg.apache.org/docs/latest/spark-queries/#querying-with-sql>
 /// - <https://py.iceberg.apache.org/api/#inspecting-tables>
 #[derive(Debug)]
-pub struct MetadataTable(Table);
+pub struct MetadataTable<'a>(&'a Table);
 
-impl MetadataTable {
+impl<'a> MetadataTable<'a> {
     /// Creates a new metadata scan.
-    pub(super) fn new(table: Table) -> Self {
+    pub(super) fn new(table: &'a Table) -> Self {
         Self(table)
     }
 
@@ -65,7 +65,7 @@ impl MetadataTable {
 
 /// Snapshots table.
 pub struct SnapshotsTable<'a> {
-    metadata_table: &'a MetadataTable,
+    metadata_table: &'a MetadataTable<'a>,
 }
 
 impl<'a> SnapshotsTable<'a> {
@@ -147,7 +147,7 @@ impl<'a> SnapshotsTable<'a> {
 /// `is_current_ancestor` indicates whether the snapshot is an ancestor of the
 /// current snapshot. If `false`, then the snapshot was rolled back.
 pub struct HistoryTable<'a> {
-    metadata_table: &'a MetadataTable,
+    metadata_table: &'a MetadataTable<'a>,
 }
 
 impl<'a> HistoryTable<'a> {

crates/iceberg/src/table.rs

@@ -22,7 +22,7 @@ use std::sync::Arc;
 use crate::arrow::ArrowReaderBuilder;
 use crate::io::object_cache::ObjectCache;
 use crate::io::FileIO;
-use crate::metadata_scan::MetadataTable;
+use crate::metadata_table::MetadataTable;
 use crate::scan::TableScanBuilder;
 use crate::spec::{TableMetadata, TableMetadataRef};
 use crate::{Error, ErrorKind, Result, TableIdent};
@@ -203,7 +203,7 @@ impl Table {
 
     /// Creates a metadata table which provides table-like APIs for inspecting metadata.
     /// See [`MetadataTable`] for more details.
-    pub fn metadata_table(self) -> MetadataTable {
+    pub fn metadata_table(&self) -> MetadataTable<'_> {
         MetadataTable::new(self)
     }