Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate methods of converting parquet file to data file builder. #1033

Closed
1 of 3 tasks
liurenjie1024 opened this issue Mar 3, 2025 · 4 comments · Fixed by #1074
Closed
1 of 3 tasks

Consolidate methods of converting parquet file to data file builder. #1033

liurenjie1024 opened this issue Mar 3, 2025 · 4 comments · Fixed by #1074
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@liurenjie1024
Copy link
Contributor

liurenjie1024 commented Mar 3, 2025

Is your feature request related to a problem or challenge?

In #960 , we introduce another method to convert ParquetMetadata to DataFileBuilder, which has a lot duplication with this method. We should consolidate the two method, but it's block by #1004 .

Describe the solution you'd like

We only need one of them, and delegate another to it.

Willingness to contribute

  • I can contribute to this feature independently
  • I would be willing to contribute to this feature with guidance from the Iceberg Rust community
  • I cannot contribute to this feature at this time
@liurenjie1024 liurenjie1024 added the enhancement New feature or request label Mar 3, 2025
@liurenjie1024 liurenjie1024 added this to the 0.5.0 Release milestone Mar 3, 2025
@liurenjie1024 liurenjie1024 added the good first issue Good for newcomers label Mar 3, 2025
@mnpw
Copy link
Contributor

mnpw commented Mar 3, 2025

Hi @liurenjie1024, I would like to work on this.

@jonathanc-n
Copy link
Contributor

@mnpw I can help try to resolve #1004 today and you can work on this after.

@liurenjie1024
Copy link
Contributor Author

Hi @liurenjie1024, I would like to work on this.

Thanks !

@jonathanc-n
Copy link
Contributor

@mnpw This pull request should be completed by #1074. Sorry about that, the two issues were intertwined. I was only able to test the metadata conversion by completing this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants