Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split transaction mod to multi files mod. #980

Closed
liurenjie1024 opened this issue Feb 20, 2025 · 3 comments · Fixed by #1080
Closed

Split transaction mod to multi files mod. #980

liurenjie1024 opened this issue Feb 20, 2025 · 3 comments · Fixed by #1080
Assignees
@liurenjie1024 @jonathanc-n
Labels
enhancement New feature or request
Milestone
0.5.0 Release

Comments

@liurenjie1024
Copy link
Contributor

As we are adding more and more transaction actions, the transaction module will become too large to maintain. We need to convert it to multi file module to make it easier to maintain.
@liurenjie1024 liurenjie1024 self-assigned this Feb 20, 2025
@liurenjie1024 liurenjie1024 added the enhancement New feature or request label Feb 20, 2025
@liurenjie1024 liurenjie1024 added this to the 0.5.0 Release milestone Feb 20, 2025
@jonathanc-n
Copy link
Contributor

I can work on this!

@liurenjie1024
Copy link
Contributor Author

I can work on this!

Thanks!

@xxchan xxchan mentioned this issue Feb 23, 2025
Open
@jonathanc-n
Copy link
Contributor

I'll work on this after #960 gets merged.

@jonathanc-n jonathanc-n mentioned this issue Mar 13, 2025
Merged
liurenjie1024 pushed a commit that referenced this issue Mar 14, 2025
@jonathanc-n
refactor: Split transaction module (#1080)
bf149d3 
## Which issue does this PR close?

- Closes #980 .

## What changes are included in this PR?

Split transactions module
Li0k pushed a commit to risingwavelabs/iceberg-rust that referenced this issue Mar 24, 2025
@jonathanc-n @Li0k
refactor: Split transaction module (apache#1080)
75372e6 
- Closes apache#980 .

Split transactions module
@Li0k Li0k mentioned this issue Mar 24, 2025
Closed
Li0k pushed a commit to risingwavelabs/iceberg-rust that referenced this issue Mar 25, 2025
@jonathanc-n @Li0k
refactor: Split transaction module (apache#1080)
278cd5c 
- Closes apache#980 .

Split transactions module
xxchan added a commit to risingwavelabs/iceberg-rust that referenced this issue Mar 25, 2025
@xxchan
refactor: Split transaction module (apache#1080)
17b658c 
- Closes apache#980 .

Split transactions module

Signed-off-by: xxchan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liurenjie1024 liurenjie1024

@jonathanc-n jonathanc-n

Labels
enhancement New feature or request
Projects
iceberg-rust
Status: Done
Milestone
0.5.0 Release
Development

Successfully merging a pull request may close this issue.

refactor: Split transaction module jonathanc-n/iceberg-rust
2 participants
@liurenjie1024 @jonathanc-n