Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

Commit 4a56248

Browse files
authored
Update Envoy (#2105)
* Leap to today's Envoy version * Fixup GoogleUrl::CopyAndAddEscapedQueryParam Signed-off-by: Otto van der Schaaf <[email protected]>
1 parent 4124bee commit 4a56248

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

.bazelrc

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ build:linux --features=per_object_debug_info
4545
build:linux --action_env=BAZEL_LINKLIBS=-l%:libstdc++.a
4646
build:linux --action_env=BAZEL_LINKOPTS=-lm
4747

48+
# TODO(keith): remove once https://github.com/DataDog/dd-opentracing-cpp/pull/252 is integrated
49+
# this avoids warnings/errors on arm64 Linux builds
50+
build:linux --per_file_copt=external/com_github_datadog_dd_opentracing_cpp/.*.cpp@-Wno-type-limits
51+
4852
# We already have absl in the build, define absl=1 to tell googletest to use absl for backtrace.
4953
build --define absl=1
5054

@@ -373,6 +377,7 @@ build:windows --define tcmalloc=disabled
373377
build:windows --define wasm=disabled
374378
build:windows --define manual_stamp=manual_stamp
375379
build:windows --cxxopt="/std:c++17"
380+
build:windows --output_groups=+pdb_file
376381

377382
# TODO(wrowe,sunjayBhatia): Resolve bugs upstream in curl and rules_foreign_cc
378383
# See issue https://github.com/bazelbuild/rules_foreign_cc/issues/301
@@ -418,4 +423,4 @@ try-import %workspace%/user.bazelrc
418423
try-import %workspace%/local_tsan.bazelrc
419424

420425
###### modifications for pagespeed
421-
try-import %workspace%/pagespeed.bazelrc
426+
import %workspace%/pagespeed.bazelrc

.bazelversion

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
6.0.0-pre.20220706.4
1+
6.0.0rc1

bazel/repositories.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ load(":aprutil.bzl", "aprutil_build_rule")
1313
load(":serf.bzl", "serf_build_rule")
1414
load(":closure_compiler.bzl", "closure_library_rules")
1515

16-
ENVOY_COMMIT = "ff49762696b2e6ed3f408a22e1f7a1b7d2487318" # Oct 11th, 2022
17-
ENVOY_SHA = "ff8303892364ec1be7e5be13e112bc45309aee2bc4da5c4ff035885367f24795"
16+
ENVOY_COMMIT = "9ae348cc43e0341ec7eadd6a4addce587afe1b27" # Nov 5th, 2022
17+
ENVOY_SHA = "f7215f2e2014c2d4123c5f7a2ba7054fdd33d8fa4ad2977c5bf45d9e231dea6d"
1818

1919
BROTLI_COMMIT = "d6d98957ca8ccb1ef45922e978bb10efca0ea541"
2020
BROTLI_SHA = "ba8be5d701b369f86d14f3701c81d6bf6c6c34015c183ff98352c12ea5f5226b"

pagespeed/kernel/http/google_url.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,8 @@ GoogleUrl* GoogleUrl::CopyAndAddEscapedQueryParam(
153153
query_params.ParseFromUrl(*this);
154154
query_params.AddEscaped(escaped_name, escaped_value);
155155
GoogleString query_params_string = query_params.ToEscapedString();
156-
url::Replacements<char> replace_query;
157-
url::Component query;
158-
query.len = query_params_string.size();
159-
replace_query.SetQuery(query_params_string.c_str(), query);
156+
GURL::Replacements replace_query;
157+
replace_query.SetQueryStr(query_params_string.c_str());
160158
GoogleUrl* result = new GoogleUrl(gurl_->ReplaceComponents(replace_query));
161159
return result;
162160
}

0 commit comments

Comments
 (0)