comments / fewer suppressions

Author: lucasbru

clients/src/main/java/org/apache/kafka/common/requests/DescribeUserScramCredentialsRequest.java

@@ -69,11 +69,11 @@ public AbstractResponse getErrorResponse(int throttleTimeMs, Throwable e) {
                 .setErrorCode(apiError.error().code())
                 .setErrorMessage(apiError.message());
 
-        for (@SuppressWarnings("UnusedLocalVariable") DescribeUserScramCredentialsRequestData.UserName ignored : data.users()) {
+        data.users().forEach(__ ->
             response.results().add(new DescribeUserScramCredentialsResponseData.DescribeUserScramCredentialsResult()
-                    .setErrorCode(apiError.error().code())
-                    .setErrorMessage(apiError.message()));
-        }
+                .setErrorCode(apiError.error().code())
+                .setErrorMessage(apiError.message()))
+        );
         return new DescribeUserScramCredentialsResponse(response);
     }
 }

clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java

@@ -2881,11 +2881,11 @@ private void verifySessionPartitions() {
                                 field.setAccessible(true);
                                 LinkedHashMap<?, ?> sessionPartitions =
                                         (LinkedHashMap<?, ?>) field.get(handler);
-                                for (@SuppressWarnings("UnusedLocalVariable") Map.Entry<?, ?> ignored : sessionPartitions.entrySet()) {
-                                    // If `sessionPartitions` are modified on another thread, Thread.yield will increase the
-                                    // possibility of ConcurrentModificationException if appropriate synchronization is not used.
-                                    Thread.yield();
-                                }
+                                // If `sessionPartitions` are modified on another thread, Thread.yield will increase the
+                                // possibility of ConcurrentModificationException if appropriate synchronization is not used.
+                                sessionPartitions.forEach(
+                                    (key, value) -> Thread.yield()
+                                );
                             } catch (Exception e) {
                                 throw new RuntimeException(e);
                             }

connect/runtime/src/test/java/org/apache/kafka/connect/integration/MonitorableSinkConnector.java

@@ -60,9 +60,7 @@ public void start(Map<String, String> props) {
         @Override
         public void put(Collection<SinkRecord> records) {
             super.put(records);
-            for (@SuppressWarnings("UnusedLocalVariable") SinkRecord ignore : records) {
-                count++;
-            }
+            count += records.size();
         }
 
     }

tools/src/main/java/org/apache/kafka/tools/ShareConsumerPerformance.java

@@ -20,10 +20,8 @@
 import org.apache.kafka.clients.consumer.ConsumerRecord;
 import org.apache.kafka.clients.consumer.ConsumerRecords;
 import org.apache.kafka.clients.consumer.KafkaShareConsumer;
-import org.apache.kafka.common.KafkaException;
 import org.apache.kafka.common.Metric;
 import org.apache.kafka.common.MetricName;
-import org.apache.kafka.common.TopicIdPartition;
 import org.apache.kafka.common.serialization.ByteArrayDeserializer;
 import org.apache.kafka.common.utils.Exit;
 import org.apache.kafka.common.utils.Utils;
@@ -40,7 +38,6 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
-import java.util.Optional;
 import java.util.Properties;
 import java.util.Set;
 import java.util.concurrent.ExecutorService;
@@ -79,8 +76,7 @@ public static void main(String[] args) {
                 shareConsumers.forEach(shareConsumer -> shareConsumersMetrics.add(shareConsumer.metrics()));
             }
             shareConsumers.forEach(shareConsumer -> {
-                @SuppressWarnings("UnusedLocalVariable")
-                Map<TopicIdPartition, Optional<KafkaException>> ignored = shareConsumer.commitSync();
+                shareConsumer.commitSync();
                 shareConsumer.close(Duration.ofMillis(500));
             });
 
@@ -118,7 +114,6 @@ private static void consume(List<KafkaShareConsumer<byte[], byte[]>> shareConsum
         AtomicLong bytesRead = new AtomicLong(0);
         List<ShareConsumerConsumption> shareConsumersConsumptionDetails = new ArrayList<>();
 
-
         ExecutorService executorService = Executors.newFixedThreadPool(shareConsumers.size());
         for (int i = 0; i < shareConsumers.size(); i++) {
             final int index = i;