Repository navigation
Commit 74fbd50
authored
MINOR: Propagate exceptions in TaskMetadataIntegrationTest (#23414)
This PR follows up on the review feedback from
#23386 (comment).
Two test methods in `TaskMetadataIntegrationTest` caught unexpected
exceptions and only printed their stack traces. This prevented those
exceptions from reaching JUnit and could allow the tests to be reported
as successful.
This change removes the catch blocks from
`shouldReportCorrectCommittedOffsetInformation` and
`shouldReportCorrectEndOffsetInformation`. Both methods now declare
`throws Exception`, allowing the original exceptions to propagate to
JUnit while retaining the existing try-with-resources cleanup.
### Testing
`./gradlew :streams:integration-tests:test --tests
org.apache.kafka.streams.integration.TaskMetadataIntegrationTest`
Reviewers: Ming-Yen Chung <mingyen066@gmail.com>, Ken Huang
<s7133700@gmail.com>1 parent 4b968c0 commit 74fbd50
1 file changed
Lines changed: 2 additions & 7 deletions
File tree
- streams/integration-tests/src/test/java/org/apache/kafka/streams/integration
Lines changed: 2 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
| 114 | + | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
135 | | - | |
136 | 134 | | |
137 | 135 | | |
138 | 136 | | |
139 | 137 | | |
140 | | - | |
| 138 | + | |
141 | 139 | | |
142 | 140 | | |
143 | 141 | | |
| |||
151 | 149 | | |
152 | 150 | | |
153 | 151 | | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | 152 | | |
158 | 153 | | |
159 | 154 | | |
| |||
0 commit comments