Skip to content

Commit 887ce01

Browse files
authored
MINOR: suppress unchecked warning in WorkerTest (#23893)
Mocking `Transformation.class` with Mockito returns a raw type, causing an unchecked conversion to `Transformation<SourceRecord>`. ``` > Task :connect:runtime:compileTestJava Note: /Users/parker/opensource/kafka/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. ``` Add a local `@SuppressWarnings("unchecked")`, following the existing approach in `TransformationStageTest.applyAndAssert`. Validation: - `./gradlew :connect:runtime:compileTestJava --rerun-tasks` - The unchecked message for WorkerTest.java no longer appeared. Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
1 parent c9da36e commit 887ce01

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

  • connect/runtime/src/test/java/org/apache/kafka/connect/runtime

‎connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -975,6 +975,7 @@ public void testStartTaskFailureAfterConverterWrappingClosesConverterPlugins(boo
975975
mockVersionedTaskConverterFromConnector(ConnectorConfig.VALUE_CONVERTER_CLASS_CONFIG, ConnectorConfig.VALUE_CONVERTER_VERSION_CONFIG, taskValueConverter);
976976
mockVersionedTaskHeaderConverterFromConnector(taskHeaderConverter);
977977

978+
@SuppressWarnings("unchecked")
978979
Transformation<SourceRecord> brokenTransform = mock(Transformation.class);
979980
when(brokenTransform.config()).thenReturn(new ConfigDef());
980981
doThrow(new RuntimeException("Failed to configure transform")).when(brokenTransform).configure(any());

0 commit comments

Comments
 (0)