Repository navigation
Commit da07836
authored
KAFKA-20843 Allow custom consumer group assignors to override built-in assignor names (#23473)
#22982 added a check that rejects a custom assignor reusing a built-in
name (e.g. uniform, range). This is a behavior change: before 4.4 such
a configuration was accepted and intentionally used to replace a
built-in assignor. Given the concerns raised in review and the upcoming
4.4 RC, this patch removes that check to restore the previous behavior.
The duplicate name check is kept, so two configured assignors resolving
to the same name still fail at startup. The streams group check is
unchanged since group.streams.assignors is new in 4.4. Whether the
strict rule should return can be revisited for 4.5.
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, David Jacot
<david.jacot@gmail.com>1 parent 3258362 commit da07836
3 files changed
Lines changed: 15 additions & 27 deletions
File tree
- docs/getting-started
- group-coordinator/src
- main/java/org/apache/kafka/coordinator/group
- test/java/org/apache/kafka/coordinator/group
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
883 | 883 | | |
884 | 884 | | |
885 | 885 | | |
886 | | - | |
| 886 | + | |
887 | 887 | | |
888 | 888 | | |
889 | | - | |
890 | | - | |
891 | | - | |
892 | | - | |
893 | | - | |
894 | | - | |
895 | 889 | | |
896 | 890 | | |
897 | 891 | | |
| |||
900 | 894 | | |
901 | 895 | | |
902 | 896 | | |
903 | | - | |
| 897 | + | |
904 | 898 | | |
905 | 899 | | |
906 | 900 | | |
| |||
919 | 913 | | |
920 | 914 | | |
921 | 915 | | |
922 | | - | |
923 | | - | |
924 | | - | |
925 | | - | |
926 | | - | |
927 | | - | |
928 | 916 | | |
929 | 917 | | |
930 | 918 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
| 105 | + | |
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| |||
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | | - | |
211 | | - | |
212 | | - | |
| 210 | + | |
| 211 | + | |
213 | 212 | | |
214 | 213 | | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
219 | 219 | | |
| 220 | + | |
220 | 221 | | |
221 | 222 | | |
222 | 223 | | |
223 | | - | |
224 | | - | |
| 224 | + | |
| 225 | + | |
225 | 226 | | |
226 | 227 | | |
227 | 228 | | |
228 | 229 | | |
229 | 230 | | |
230 | | - | |
231 | | - | |
| 231 | + | |
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
| |||
0 commit comments