Skip to content

Commit f6912a9

Browse files
authored
MINOR: Fix typo in DumpLogSegments' TransactionLogMessageParser (#18505)
The value should use `version` instead of `type`. Reviewers: Jeff Kim <[email protected]>, Chia-Ping Tsai <[email protected]>
1 parent da0c3be commit f6912a9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

core/src/main/scala/kafka/tools/DumpLogSegments.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ object DumpLogSegments {
548548
}
549549

550550
val json = new ObjectNode(JsonNodeFactory.instance)
551-
json.set("type", new TextNode(version.toString))
551+
json.set("version", new TextNode(version.toString))
552552
json.set("data", messageAsJson)
553553
json.toString
554554
}

core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -858,7 +858,7 @@ class DumpLogSegmentsTest {
858858
assertEquals(
859859
(
860860
Some("{\"type\":\"0\",\"data\":{\"transactionalId\":\"txnId\"}}"),
861-
Some("{\"type\":\"0\",\"data\":{\"producerId\":123,\"producerEpoch\":0,\"transactionTimeoutMs\":0," +
861+
Some("{\"version\":\"0\",\"data\":{\"producerId\":123,\"producerEpoch\":0,\"transactionTimeoutMs\":0," +
862862
"\"transactionStatus\":0,\"transactionPartitions\":[],\"transactionLastUpdateTimestampMs\":0," +
863863
"\"transactionStartTimestampMs\":0}}")
864864
),
@@ -915,7 +915,7 @@ class DumpLogSegmentsTest {
915915
assertEquals(
916916
(
917917
Some("{\"type\":\"0\",\"data\":{\"transactionalId\":\"txnId\"}}"),
918-
Some("{\"type\":\"1\",\"data\":{\"producerId\":12,\"previousProducerId\":11,\"nextProducerId\":10," +
918+
Some("{\"version\":\"1\",\"data\":{\"producerId\":12,\"previousProducerId\":11,\"nextProducerId\":10," +
919919
"\"producerEpoch\":2,\"transactionTimeoutMs\":14,\"transactionStatus\":0," +
920920
"\"transactionPartitions\":[{\"topic\":\"topic1\",\"partitionIds\":[0,1,2]}," +
921921
"{\"topic\":\"topic2\",\"partitionIds\":[3,4,5]}],\"transactionLastUpdateTimestampMs\":123," +

0 commit comments

Comments
 (0)