diff --git a/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorExecutorImpl.java b/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorExecutorImpl.java index bcd8fc795fb89..986bcd1c5b014 100644 --- a/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorExecutorImpl.java +++ b/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorExecutorImpl.java @@ -107,7 +107,7 @@ public boolean schedule( "the coordinator is not active.", key, exception.getMessage()); } else { log.error("The write event for the task {} failed due to {}. Ignoring it. ", - key, exception.getMessage()); + key, exception.getMessage(), exception); } return null; diff --git a/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java b/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java index 552e7e72effd8..06017417233a3 100644 --- a/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java +++ b/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java @@ -399,7 +399,7 @@ public void run() { schedule(key, retryBackoff, TimeUnit.MILLISECONDS, true, retryBackoff, operation); } else { log.error("The write event {} for the timer {} failed due to {}. Ignoring it. ", - event.name, key, ex.getMessage()); + event.name, key, ex.getMessage(), ex); } return null; @@ -717,7 +717,7 @@ private void load() { } } catch (Throwable ex) { log.error("Failed to load metadata from {} with epoch {} due to {}.", - tp, epoch, ex.toString()); + tp, epoch, ex.getMessage(), ex); context.transitionTo(CoordinatorState.FAILED); } } else { @@ -820,7 +820,7 @@ private void flushCurrentBatch() { // Free up the current batch. freeCurrentBatch(); } catch (Throwable t) { - log.error("Writing records to {} failed due to: {}.", tp, t.getMessage()); + log.error("Writing records to {} failed due to: {}.", tp, t.getMessage(), t); failCurrentBatch(t); // We rethrow the exception for the caller to handle it too. throw t; @@ -1057,7 +1057,7 @@ private void append( currentBatch.builder.append(recordToAppend); currentBatch.nextOffset++; } catch (Throwable t) { - log.error("Replaying record {} to {} failed due to: {}.", recordToReplay, tp, t.getMessage()); + log.error("Replaying record {} to {} failed due to: {}.", recordToReplay, tp, t.getMessage(), t); // Add the event to the list of pending events associated with the last // batch in order to fail it too. @@ -2446,7 +2446,7 @@ public void scheduleUnloadOperation( // It's very unlikely that we will ever see an exception here, since we // already make an effort to catch exceptions in the unload method. log.error("Failed to unload metadata for {} with epoch {} due to {}.", - tp, partitionEpoch, ex.toString()); + tp, partitionEpoch, ex.getMessage(), ex); } finally { // Always remove the coordinator context, otherwise the coordinator // shard could be permanently stuck. diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java index 3cb59ca3f81ec..9c300c529b52a 100644 --- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java +++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java @@ -1825,7 +1825,7 @@ private CompletableFuture { if (error != null) { - log.error("Failed to read summary of the share partition"); + log.error("Failed to read summary of the share partition", error); future.completeExceptionally(error); return; } diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java index 09b459a27f797..f9150140036c5 100644 --- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java +++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java @@ -3418,7 +3418,7 @@ private CoordinatorResult handleRegularExpressionsResul ) { if (exception != null) { log.error("[GroupId {}] Couldn't update regular expression due to: {}", - groupId, exception.getMessage()); + groupId, exception.getMessage(), exception); return new CoordinatorResult<>(List.of()); } @@ -3894,7 +3894,7 @@ private Assignment updateTargetAssignment( } catch (PartitionAssignorException ex) { String msg = String.format("Failed to compute a new target assignment for epoch %d: %s", groupEpoch, ex.getMessage()); - log.error("[GroupId {}] {}.", group.groupId(), msg); + log.error("[GroupId {}] {}.", group.groupId(), msg, ex); throw new UnknownServerException(msg, ex); } } @@ -3955,7 +3955,7 @@ private Assignment updateTargetAssignment( } catch (PartitionAssignorException ex) { String msg = String.format("Failed to compute a new target assignment for epoch %d: %s", groupEpoch, ex.getMessage()); - log.error("[GroupId {}] {}.", group.groupId(), msg); + log.error("[GroupId {}] {}.", group.groupId(), msg, ex); throw new UnknownServerException(msg, ex); } } @@ -4014,7 +4014,7 @@ private TasksTuple updateStreamsTargetAssignment( } catch (TaskAssignorException ex) { String msg = String.format("Failed to compute a new target assignment for epoch %d: %s", groupEpoch, ex.getMessage()); - log.error("[GroupId {}] {}.", group.groupId(), msg); + log.error("[GroupId {}] {}.", group.groupId(), msg, ex); throw new UnknownServerException(msg, ex); } }