Ignore more rules and fix more issues

Author: turbaszek

.github/workflows/ci.yaml

@@ -27,6 +27,9 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-python@v2
+        with:
+          python-version: '3.8'
+      - run: pip install '.[devel]'
       - uses: pre-commit/[email protected]
         with:
           extra_args: --show-diff-on-failure

kibble/api/handler.py

@@ -54,6 +54,7 @@
 
 class KibbleHTTPError(Exception):
     def __init__(self, code, message):
+        super().__init__()
         self.code = code
         self.message = message
 
@@ -75,7 +76,7 @@ def __call__(self, environ, start_response, session):
             # Read JSON client data if any
             try:
                 request_size = int(environ.get("CONTENT_LENGTH", 0))
-            except (ValueError):
+            except ValueError:
                 request_size = 0
             requestBody = environ["wsgi.input"].read(request_size)
             formdata = {}
@@ -123,7 +124,7 @@ def __call__(self, environ, start_response, session):
                 ) + "\n"
                 return
 
-        except:
+        except:  # pylint: disable=bare-except
             err_type, err_value, tb = sys.exc_info()
             traceback_output = ["API traceback:"]
             traceback_output += traceback.format_tb(tb)
@@ -133,7 +134,7 @@ def __call__(self, environ, start_response, session):
                 start_response(
                     "500 Internal Server Error", [("Content-Type", "application/json")]
                 )
-            except:
+            except:  # pylint: disable=bare-except
                 pass
             yield json.dumps({"code": "500", "reason": "\n".join(traceback_output)})
 
@@ -142,7 +143,6 @@ def fourohfour(environ, start_response):
     """A very simple 404 handler"""
     start_response("404 Not Found", [("Content-Type", "application/json")])
     yield json.dumps({"code": 404, "reason": "API endpoint not found"}, indent=4) + "\n"
-    return
 
 
 def application(environ, start_response):
@@ -164,7 +164,7 @@ def application(environ, start_response):
                     session.headers.append(bucket)
                     try:
                         start_response("200 Okay", session.headers)
-                    except:
+                    except:  # pylint: disable=bare-except
                         pass
                 a += 1
                 # WSGI prefers byte strings, so convert if regular py3 string

kibble/api/pages/bio/newtimers.py

@@ -75,10 +75,10 @@ def find_earlier(session, query, when, who, which, where, doctype, dOrg):
     if "aggs" in query:
         del query["aggs"]
 
-    rangeQuery = {"range": {which: {"from": 0, "to": time.time()}}}
+    range_query = {"range": {which: {"from": 0, "to": time.time()}}}
 
     query["query"]["bool"]["must"] = [
-        rangeQuery,
+        range_query,
         {"term": {"organisation": dOrg}},
         {"term": {where: who}},
     ]
@@ -90,10 +90,7 @@ def find_earlier(session, query, when, who, which, where, doctype, dOrg):
         doc = res["hits"]["hits"][0]["_source"]
         if doc[which] >= when:
             return [doc[which], doc]
-        else:
-            return [-1, None]
-    else:
-        return [-1, None]
+    return [-1, None]
 
 
 def run(API, environ, indata, session):

kibble/api/pages/ci/queue.py

@@ -65,7 +65,6 @@
 This is the CI queue timeseries renderer for Kibble
 """
 
-import hashlib
 import json
 import time
 

kibble/api/pages/ci/status.py

@@ -65,7 +65,6 @@
 This is the CI queue status (blocked/stuck) timeseries renderer for Kibble
 """
 
-import hashlib
 import json
 import time
 

kibble/api/pages/ci/top-buildcount.py

@@ -66,7 +66,6 @@
 """
 
 import json
-import re
 import time
 
 

kibble/api/pages/ci/top-buildtime.py

@@ -66,7 +66,6 @@
 """
 
 import json
-import re
 import time
 
 

kibble/api/pages/code/commits.py

@@ -65,7 +65,7 @@
 This is the TopN committers list renderer for Kibble
 """
 
-import hashlib
+
 import json
 import time
 

kibble/api/pages/code/evolution.py

@@ -65,7 +65,7 @@
 This is the TopN committers list renderer for Kibble
 """
 
-import hashlib
+
 import json
 import time
 
@@ -119,7 +119,7 @@ def run(API, environ, indata, session):
     )
     sid = res["_scroll_id"]
     scroll_size = res["hits"]["total"]
-    if type(scroll_size) is dict:
+    if isinstance(scroll_size, dict):
         scroll_size = scroll_size["value"]  # ES >= 7.x
 
     timeseries = []

kibble/api/pages/code/pony-timeseries.py

@@ -67,7 +67,6 @@
 
 import datetime
 import json
-import re
 import time
 
 import dateutil.relativedelta