fix overflows in compound assignments (#11938)

* Count points as longs.

* Simplify KnnVectorsWriter.

Co-authored-by: Adrien Grand <[email protected]>

Author: rmuir

lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java

@@ -108,7 +108,6 @@ public int nextDoc() throws IOException {
   protected static class MergedVectorValues extends VectorValues {
     private final List<VectorValuesSub> subs;
     private final DocIDMerger<VectorValuesSub> docIdMerger;
-    private final int cost;
     private final int size;
 
     private int docId;
@@ -136,12 +135,10 @@ private MergedVectorValues(List<VectorValuesSub> subs, MergeState mergeState)
         throws IOException {
       this.subs = subs;
       docIdMerger = DocIDMerger.of(subs, mergeState.needsIndexSort);
-      int totalCost = 0, totalSize = 0;
+      int totalSize = 0;
       for (VectorValuesSub sub : subs) {
-        totalCost += sub.values.cost();
         totalSize += sub.values.size();
       }
-      cost = totalCost;
       size = totalSize;
       docId = -1;
     }
@@ -184,7 +181,7 @@ public int size() {
 
     @Override
     public long cost() {
-      return cost;
+      return size;
     }
 
     @Override

lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java

@@ -415,7 +415,7 @@ private long pointCount(
           BiFunction<byte[], byte[], Relation> nodeComparator,
           Predicate<byte[]> leafComparator)
           throws IOException {
-        final int[] matchingNodeCount = {0};
+        final long[] matchingNodeCount = {0};
         // create a custom IntersectVisitor that records the number of leafNodes that matched
         final IntersectVisitor visitor =
             new IntersectVisitor() {
@@ -446,7 +446,7 @@ public Relation compare(byte[] minPackedValue, byte[] maxPackedValue) {
       }
 
       private void pointCount(
-          IntersectVisitor visitor, PointValues.PointTree pointTree, int[] matchingNodeCount)
+          IntersectVisitor visitor, PointValues.PointTree pointTree, long[] matchingNodeCount)
           throws IOException {
         Relation r = visitor.compare(pointTree.getMinPackedValue(), pointTree.getMaxPackedValue());
         switch (r) {

lucene/core/src/java/org/apache/lucene/util/OfflineSorter.java

@@ -141,7 +141,7 @@ public class SortInfo {
     /** number of partition merges */
     public int mergeRounds;
     /** number of lines of data read */
-    public int lineCount;
+    public long lineCount;
     /** time spent merging sorted partitions (in milliseconds) */
     public final AtomicLong mergeTimeMS = new AtomicLong();
     /** time spent sorting data (in milliseconds) */