ecj: enable redundantSpecificationOfTypeArguments and fix issues (#14965)

One of the easier ECJ checks to enable and fix: although a bit cosmetic
it is also the least risky. Makes the code look a little less java 5 and
a little more java 24, especially if we address other ECJ issues.

Author: rmuir

gradle/validation/ecj-lint/ecj.javadocs.prefs

@@ -95,7 +95,7 @@ org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
 org.eclipse.jdt.core.compiler.problem.rawTypeReference=error
 org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=error
 org.eclipse.jdt.core.compiler.problem.redundantNullCheck=error
-org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=ignore
+org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=error
 org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=error
 org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore
 org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore

lucene/analysis/common/src/java/org/apache/lucene/analysis/morph/ViterbiNBest.java

@@ -61,7 +61,7 @@ protected ViterbiNBest(
   protected final void backtraceNBest(final Position endPosData, final boolean useEOS)
       throws IOException {
     if (lattice == null) {
-      lattice = new Lattice<U>();
+      lattice = new Lattice<>();
     }
 
     final int endPos = endPosData.getPos();

lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymGraphFilter.java

@@ -118,7 +118,7 @@ public final class SynonymGraphFilter extends TokenFilter {
   private int lookaheadNextWrite;
 
   private RollingBuffer<BufferedInputToken> lookahead =
-      new RollingBuffer<BufferedInputToken>() {
+      new RollingBuffer<>() {
         @Override
         protected BufferedInputToken newInstance() {
           return new BufferedInputToken();

lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestFactories.java

@@ -157,7 +157,7 @@ private AbstractAnalysisFactory initialize(Class<? extends AbstractAnalysisFacto
 
   // some silly classes just so we can use checkRandomData
   private TokenizerFactory assertingTokenizer =
-      new TokenizerFactory(new HashMap<String, String>()) {
+      new TokenizerFactory(new HashMap<>()) {
         @Override
         public MockTokenizer create(AttributeFactory factory) {
           return new MockTokenizer(factory);

lucene/analysis/common/src/test/org/apache/lucene/analysis/minhash/TestMinHashFilter.java

@@ -75,8 +75,8 @@ public void testHashOrder() {
     assertTrue(MinHashFilter.isLessThanUnsigned(1L, 2L));
     assertTrue(MinHashFilter.isLessThanUnsigned(Long.MAX_VALUE, Long.MIN_VALUE));
 
-    FixedSizeTreeSet<LongPair> minSet = new FixedSizeTreeSet<LongPair>(500);
-    HashSet<LongPair> unadded = new HashSet<LongPair>();
+    FixedSizeTreeSet<LongPair> minSet = new FixedSizeTreeSet<>(500);
+    HashSet<LongPair> unadded = new HashSet<>();
     for (int i = 0; i < 100; i++) {
       LongPair hash = new LongPair();
       MinHashFilter.murmurhash3_x64_128(MinHashFilter.getBytes(i), 0, 4, 0, hash);
@@ -100,9 +100,9 @@ public void testHashOrder() {
   }
 
   public void testCollisions() {
-    HashSet<LongPair> collisionDetection = new HashSet<LongPair>();
-    HashSet<LongPair> unadded = new HashSet<LongPair>();
-    FixedSizeTreeSet<LongPair> minSet = new FixedSizeTreeSet<LongPair>(500);
+    HashSet<LongPair> collisionDetection = new HashSet<>();
+    HashSet<LongPair> unadded = new HashSet<>();
+    FixedSizeTreeSet<LongPair> minSet = new FixedSizeTreeSet<>(500);
     int numElements = TEST_NIGHTLY ? 1000000 : 10000;
     for (int i = 0; i < numElements; i++) {
       LongPair hash = new LongPair();
@@ -139,8 +139,8 @@ public void testCollisions() {
 
   @Test
   public void testHashNotRepeated() {
-    FixedSizeTreeSet<LongPair> minSet = new FixedSizeTreeSet<LongPair>(500);
-    HashSet<LongPair> unadded = new HashSet<LongPair>();
+    FixedSizeTreeSet<LongPair> minSet = new FixedSizeTreeSet<>(500);
+    HashSet<LongPair> unadded = new HashSet<>();
     for (int i = 0; i < 10000; i++) {
       LongPair hash = new LongPair();
       MinHashFilter.murmurhash3_x64_128(MinHashFilter.getBytes(i), 0, 4, 0, hash);

lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/TestICUFoldingFilterFactory.java

@@ -28,15 +28,15 @@ public class TestICUFoldingFilterFactory extends BaseTokenStreamTestCase {
   /** basic tests to ensure the folding is working */
   public void test() throws Exception {
     Reader reader = new StringReader("Résumé");
-    ICUFoldingFilterFactory factory = new ICUFoldingFilterFactory(new HashMap<String, String>());
+    ICUFoldingFilterFactory factory = new ICUFoldingFilterFactory(new HashMap<>());
     TokenStream stream = whitespaceMockTokenizer(reader);
     stream = factory.create(stream);
     assertTokenStreamContents(stream, new String[] {"resume"});
   }
 
   /** test to ensure the filter parameter is working */
   public void testFilter() throws Exception {
-    HashMap<String, String> args = new HashMap<String, String>();
+    HashMap<String, String> args = new HashMap<>();
     args.put("filter", "[^ö]");
     ICUFoldingFilterFactory factory = new ICUFoldingFilterFactory(args);
 

lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/TestICUNormalizer2CharFilterFactory.java

@@ -29,8 +29,7 @@ public class TestICUNormalizer2CharFilterFactory extends BaseTokenStreamTestCase
   /** Test nfkc_cf defaults */
   public void testDefaults() throws Exception {
     Reader reader = new StringReader("This is a Ｔｅｓｔ");
-    ICUNormalizer2CharFilterFactory factory =
-        new ICUNormalizer2CharFilterFactory(new HashMap<String, String>());
+    ICUNormalizer2CharFilterFactory factory = new ICUNormalizer2CharFilterFactory(new HashMap<>());
     reader = factory.create(reader);
     TokenStream stream = whitespaceMockTokenizer(reader);
     assertTokenStreamContents(stream, new String[] {"this", "is", "a", "test"});

lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/TestICUNormalizer2FilterFactory.java

@@ -29,8 +29,7 @@ public class TestICUNormalizer2FilterFactory extends BaseTokenStreamTestCase {
   /** Test nfkc_cf defaults */
   public void testDefaults() throws Exception {
     Reader reader = new StringReader("This is a Ｔｅｓｔ");
-    ICUNormalizer2FilterFactory factory =
-        new ICUNormalizer2FilterFactory(new HashMap<String, String>());
+    ICUNormalizer2FilterFactory factory = new ICUNormalizer2FilterFactory(new HashMap<>());
     TokenStream stream = whitespaceMockTokenizer(reader);
     stream = factory.create(stream);
     assertTokenStreamContents(stream, new String[] {"this", "is", "a", "test"});

lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/segmentation/TestICUTokenizerFactory.java

@@ -28,7 +28,7 @@
 public class TestICUTokenizerFactory extends BaseTokenStreamTestCase {
   public void testMixedText() throws Exception {
     Reader reader = new StringReader("การที่ได้ต้องแสดงว่างานดี  This is a test ກວ່າດອກ");
-    ICUTokenizerFactory factory = new ICUTokenizerFactory(new HashMap<String, String>());
+    ICUTokenizerFactory factory = new ICUTokenizerFactory(new HashMap<>());
     factory.inform(new ClasspathResourceLoader(getClass()));
     Tokenizer stream = factory.create(newAttributeFactory());
     stream.setReader(reader);

lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestFactories.java

@@ -155,7 +155,7 @@ private AbstractAnalysisFactory initialize(Class<? extends AbstractAnalysisFacto
 
   // some silly classes just so we can use checkRandomData
   private TokenizerFactory assertingTokenizer =
-      new TokenizerFactory(new HashMap<String, String>()) {
+      new TokenizerFactory(new HashMap<>()) {
         @Override
         public MockTokenizer create(AttributeFactory factory) {
           return new MockTokenizer(factory);