Enhance target JDK definition for JDK >= 9 #505
Conversation
Defining maven.compiler.source and maven.compiler.target properties when running on JDK >= 9 has some side effects. Fixes apache#503
|
@slachiewicz @slawekjaranowski Note that those could be potentially moved to apache-parent if we want. Thoughts ? |
gnodet
changed the title
| <javaVersion>8</javaVersion> | ||
| <maven.compiler.source>${javaVersion}</maven.compiler.source> | ||
| <maven.compiler.target>${javaVersion}</maven.compiler.target> | ||
| <maven.compiler.source /> |
There was a problem hiding this comment.
I'm not sure if it works on Maven 3 ....
Maybe we can do it in ASF parent?
There was a problem hiding this comment.
I'm not sure if it works on Maven 3 ....
Maven 3 already requires JDK 17 to build.
I tested the PR on maven-compiler-plugin on the maven-compiler-plugin-3.x branch with success.
Maybe we can do it in ASF parent?
Yes, definitely. There's a higher risk of disruption and currently, the main target for this change is the master branch of maven-compiler-plugin, but I'm fine with moving it up if we want.
There was a problem hiding this comment.
I agree to move up, looks safe
|
I've raised apache/maven-apache-parent#543 but we'll need to keep this PR. |
| <maven.compiler.source /> | ||
| <maven.compiler.target /> |
There was a problem hiding this comment.
| <maven.compiler.source /> | |
| <maven.compiler.target /> |
is this the same now?
Having implicit or explicit default/undefined value is the same outcome, right?
3 participants
Defining maven.compiler.source and maven.compiler.target properties when
running on JDK >= 9 has some side effects.
Fixes #503