[MSOURCES-8] maven-source-plugin causes generate-sources phase to execute twice

[jira-importer]

Andreas Schildbach opened MSOURCES-8 and commented

Due to the lack of documentation, I configured the plugin as follows, in order to install sources when doing "mvn install":

<plugin>
     <groupId>org.apache.maven.plugins</groupId>
     <artifactId>maven-source-plugin</artifactId>
     <executions>
          <execution>
                   <phase>install</phase>
                   <goals>
                            <goal>jar</goal>
                   </goals>
          </execution>
     </executions>
</plugin>

Unfortunately, "mvn install" causes the generate-sources phase to execute twice, which can manifest for example in an antrun-task executing twice.

---

Affects: 2.0.1

Issue Links:

• MSOURCES-13 No-Forking mojos for use within a POM instead of CLI

2 votes, 6 watchers

[jira-importer]

Andreas Schildbach commented

I suspect the @execute phase="generate-sources" in the Mojo is responsible for this behaviour. What is this good for? The Mojo is bound with @phase package, so generate-sources should already have run.

[jira-importer]

Jason van Zyl commented

The @execute phase="generate-sources" is there so that if you run

mvn source:jar

From the command line any sources will be generated before the source jar is made. We should more then likely not allow this but that's the reasoning.

[jira-importer]

duality72 commented

I don't think that's a very satisfactory answer. Ensuring the generate-sources phase runs first is fine, but it needs to be done in such a way that it's not repeated in a normal build process. This is potentially buggy and could cause a lot of useless overhead. I would suggest at least one of the following:

1. Remove the @execute phase. If someone wants to generate a source jar from the command line ensuring they get all generated source, they can do 'mvn generate-sources source:jar'. Still not ideal, but it's a bug with a workaround and happens far less often (on the rare occasion someone builds a source jar from the command line) instead of every single time a build occurs.

2. If detecting that the generate-sources phase has already run is not something that the plugin can do, then there should be a bug to the Maven framework for just this sort of situation. I know similar situations happen with testing and code coverage.

3. At the very least, this bug should remain open to be addressed at a later date; perhaps downgrade the priority to minor, though.

[jira-importer]

Moiz Dohadwala commented

I concur with Chris Hilton especially on #2.

If the source plugin needs to ensure that generate-sources has run, then it should first check if it has already run. This is a big problem for us. Running generate-sources twice causing source code to be generated with different identifiers the second time ( 3rd party tools that we have to use ). We should at the very least have a way in the pom.xml to configure the source plugin to not run it. We never run source:jar from the command line. In my opinion maven developers have prioritized an uncommon command line usage usa case over the more common use case of users simply including the source plugin in the build section.

This bug should be re-opened.

[jira-importer]

Malachi de AElfweald commented

I agree. In my case, it forces initialize to run twice which is causing the build to fail. Since this is to not be fixed, I guess the only workaround is to quit using the maven-source-plugin.

[jira-importer]

Dennis Lundberg commented

Please also see related issue MSOURCES-13.

[jira-importer]

Vadim Kopichenko commented

Workaround: http://stackoverflow.com/questions/4251488/maven-release-plugin-fails-source-artifacts-getting-deployed-twice