[MSOURCES-21] Allow classes to be bundled with the source code

[jira-importer]

Tom Schneider opened MSOURCES-21 and commented

We have the need to bundle the compiled class files with the source code and other resources. So I created a patch that adds a new configuration point (includeClasses) that when set to true, will bundle not only the source code and resources, but also the generated class files.

---

Affects: 2.0.3

Attachments:

• sourceplugin-includeClasses.patch (4.45 kB)

[jira-importer]

Benjamin Bentmann commented

There seems to be a problem with your patch: The mojos might not see any class files for packaging since the mojos only depend on the "generate-source" phase but class files are not created until "compile" phase. However, increasing the lifecycle requirements of the mojos will slow down the plugin and might make it unattractive to many users with simpler use cases.

For the above reasons, I would not expect your patch to get included. Instead, I suggest you have a look at the maven-assembly-plugin. Its configuration is a bit more expensive but it can handle quite a lot of packaging stuff. Because it requires the "package" phase, there should be no problems about inclusion of compiled classes.

[jira-importer]

Wendy Smoak commented

Wouldn't it make more sense to include the source code in the normal jar file?

[jira-importer]

Dennis Lundberg commented

I agree with Benjamin here. This sounds like a case for the assembly-plugin.

[jira-importer]

Tom Schneider commented

For a single project, I think the assembly plugin is an ok solution. However, for a multimodule project were you want to build a jar for each submodule in a standard way I don't think that's a good solution. (At least with whats currently available from the assembly plugin) I did go down that route before I created this patch. I think it may make more sense to create a separate plugin that has the behavior that I was looking for. (It would definitely ease the configuration IMO)

Fortunately, I no longer have a need for this functionality. This was needed to mimic the way our old system built source jars, but we've decided to strongarm our other projects into fully adopting maven. So I'm ok with this not being implemented.

[jira-importer]

Tom Schneider commented

Not needed anymore and the included patch has phase dependency issues.