Skip to content

Commit 8cf2396

Browse files
committed
fix unit tests
Signed-off-by: Olivier Lamy <[email protected]>
1 parent cfba449 commit 8cf2396

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,7 @@ public abstract class AbstractSurefireMojo extends AbstractMojo implements Suref
745745

746746
private Logger logger = LoggerFactory.getLogger(getClass());
747747

748-
private final PluginConsoleLogger consoleLogger = new PluginConsoleLogger(logger);
748+
private PluginConsoleLogger consoleLogger = new PluginConsoleLogger(logger);
749749

750750
/**
751751
* (TestNG only) Define the factory class used to create all test instances.
@@ -974,12 +974,17 @@ public void execute() throws MojoExecutionException, MojoFailureException {
974974

975975
void setLogger(Logger logger) {
976976
this.logger = logger;
977+
this.consoleLogger = new PluginConsoleLogger(logger);
977978
}
978979

979980
void setSurefireDependencyResolver(SurefireDependencyResolver surefireDependencyResolver) {
980981
this.surefireDependencyResolver = surefireDependencyResolver;
981982
}
982983

984+
SurefireDependencyResolver getSurefireDependencyResolver() {
985+
return surefireDependencyResolver;
986+
}
987+
983988
@Nonnull
984989
protected final PluginConsoleLogger getConsoleLogger() {
985990
return consoleLogger;

maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ private StartupConfiguration startupConfigurationForProvider(ProviderInfo provid
609609
File classesDir = mockFile("classes");
610610
File testClassesDir = mockFile("test-classes");
611611
TestClassPath testClassPath =
612-
new TestClassPath(new ArrayList<Artifact>(), classesDir, testClassesDir, Collections.emptyList());
612+
new TestClassPath(new ArrayList<>(), classesDir, testClassesDir, Collections.emptyList());
613613

614614
Artifact common = new DefaultArtifact(
615615
"org.apache.maven.surefire",
@@ -1748,7 +1748,6 @@ public void shouldSmartlyResolveJUnit5ProviderWithJupiterEngineInPluginDependenc
17481748
assertThat(junitPlatformArtifact.getArtifactId()).isEqualTo("junit-platform-engine");
17491749
assertThat(junitPlatformArtifact.getVersion()).isEqualTo("1.4.0");
17501750

1751-
17521751
PluginDescriptor pluginDescriptor = mock(PluginDescriptor.class);
17531752
mojo.setPluginDescriptor(pluginDescriptor);
17541753
Plugin p = mock(Plugin.class);
@@ -1761,7 +1760,6 @@ public void shouldSmartlyResolveJUnit5ProviderWithJupiterEngineInPluginDependenc
17611760

17621761
assertThat(prov.isApplicable()).isTrue();
17631762

1764-
17651763
Artifact surefireProvider = new DefaultArtifact(
17661764
"org.apache.maven.surefire", "surefire-junit-platform", surefireVersion, null, "jar", "", null);
17671765
Artifact java5 = new DefaultArtifact(
@@ -1951,8 +1949,8 @@ private JUnitPlatformProviderInfo createJUnitPlatformProviderInfo(
19511949
testClasspathWrapper,
19521950
null,
19531951
null,
1954-
getBooterArtifact() ,
1955-
mock(SurefireDependencyResolver.class),
1952+
getBooterArtifact(),
1953+
getSurefireDependencyResolver(),
19561954
mock(MavenSession.class),
19571955
mock(MavenProject.class),
19581956
getPluginDescriptor(),

0 commit comments

Comments
 (0)