Issue #17487: Apply StreamRulesRecipes

- checkstyle/checkstyle#17782

Author: Vincent Potucek

compat/maven-compat/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java

@@ -202,9 +202,7 @@ public ResolutionGroup retrieve(MetadataResolutionRequest request) throws Artifa
             if (session != null) {
                 if (session.getProjects() != null) {
                     pomRepositories = session.getProjects().stream()
-                            .filter(p -> artifact.equals(p.getArtifact()))
-                            .map(MavenProject::getRemoteArtifactRepositories)
-                            .findFirst()
+                            .filter(p -> artifact.equals(p.getArtifact())).findFirst().map(MavenProject::getRemoteArtifactRepositories)
                             .orElseGet(() -> getRepositoriesFromModel(repositorySession, model));
                 } else {
                     pomRepositories = getRepositoriesFromModel(repositorySession, model);

impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnup/goals/CompatibilityFixStrategy.java

@@ -533,9 +533,7 @@ private Path findParentPomInMap(
                             && Objects.equals(gav.groupId(), groupId)
                             && Objects.equals(gav.artifactId(), artifactId)
                             && (version == null || Objects.equals(gav.version(), version));
-                })
-                .map(Map.Entry::getKey)
-                .findFirst()
+                }).findFirst().map(Map.Entry::getKey)
                 .orElse(null);
     }
 

impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java

@@ -278,9 +278,7 @@ protected <Q> Supplier<Q> compile(Binding<Q> binding) {
         Supplier<Q> compiled = binding.compile(this::getCompiledBinding);
         if (binding.getScope() != null) {
             Scope scope = scopes.entrySet().stream()
-                    .filter(e -> e.getKey().isInstance(binding.getScope()))
-                    .map(Map.Entry::getValue)
-                    .findFirst()
+                            .filter(e -> e.getKey().isInstance(binding.getScope())).findFirst().map(Map.Entry::getValue)
                     .orElseThrow(() -> new DIException("Scope not bound for annotation "
                             + binding.getScope().annotationType()))
                     .get();

impl/maven-testing/src/main/java/org/apache/maven/api/plugin/testing/MojoExtension.java

@@ -264,9 +264,7 @@ public Object resolveParameter(ParameterContext parameterContext, ExtensionConte
 
             XmlNode pluginConfiguration = model.getBuild().getPlugins().stream()
                     .filter(p ->
-                            Objects.equals(p.getGroupId(), coord[0]) && Objects.equals(p.getArtifactId(), coord[1]))
-                    .map(ConfigurationContainer::getConfiguration)
-                    .findFirst()
+                            Objects.equals(p.getGroupId(), coord[0]) && Objects.equals(p.getArtifactId(), coord[1])).findFirst().map(ConfigurationContainer::getConfiguration)
                     .orElseGet(() -> XmlNode.newInstance("config"));
             List<XmlNode> children = mojoParameters.stream()
                     .map(mp -> XmlNode.newInstance(mp.name(), mp.value()))

impl/maven-xml/src/main/java/org/apache/maven/internal/xml/DefaultXmlService.java

@@ -311,11 +311,9 @@ public XmlNode doMerge(XmlNode dominant, XmlNode recessive, Boolean childMergeOv
                         String name = recessiveChild.name();
                         Iterator<XmlNode> it =
                                 commonChildren.computeIfAbsent(name, n1 -> Stream.of(dominant.children().stream()
-                                                .filter(n2 -> n2.name().equals(n1))
-                                                .collect(Collectors.toList()))
-                                        .filter(l -> !l.isEmpty())
-                                        .map(List::iterator)
-                                        .findFirst()
+                                        .filter(n2 -> n2.name().equals(n1))
+                                        .collect(Collectors.toList()))
+                                        .filter(l -> !l.isEmpty()).findFirst().map(List::iterator)
                                         .orElse(null));
                         if (it == null) {
                             if (children == null) {

its/core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/Verifier.java

@@ -195,9 +195,7 @@ public void execute() throws VerificationException {
             String outerHead = outerLocalRepository.toString();
 
             String itTail = args.stream()
-                    .filter(s -> s.startsWith("-Dmaven.repo.local.tail="))
-                    .map(s -> s.substring(24).trim())
-                    .findFirst()
+                    .filter(s -> s.startsWith("-Dmaven.repo.local.tail=")).findFirst().map(s -> s.substring(24).trim())
                     .orElse("");
             if (!itTail.isEmpty()) {
                 // remove it