-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Repository layout should be used in MavenRepositorySystem #11495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository layout should be used in MavenRepositorySystem #11495
Conversation
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
Outdated
Show resolved
Hide resolved
dfba78a to
1d01e2d
Compare
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
Outdated
Show resolved
Hide resolved
Bukama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few typos only
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
Outdated
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
Outdated
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
Show resolved
Hide resolved
1d01e2d to
ff6e032
Compare
|
Does this fix the Tycho issue? or is unrelated? |
Fix Tycho issue - confirmed by test provided in issue |
|
Tycho use own repo layouts like: so we can not override it be default |
|
Of course, I just wanted to make sure does this fix Tycho. @laeubi |
|
@slawekjaranowski thanks for looking into this 👍 I wonder if there is a good way to let Tycho test maven snapshots? I think we have had a job in the past but it was deleted because it was broken once in a while, but maybe in the meantime there are better ways to fetching snapshots? |
Snapshot are published to https://repository.apache.org/ so is only one palce to fetch |
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.