Skip to content

Conversation

@slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski slawekjaranowski self-assigned this Nov 26, 2025
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Nov 26, 2025
@slawekjaranowski slawekjaranowski linked an issue Nov 26, 2025 that may be closed by this pull request
Copy link
Contributor

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typos only

@slawekjaranowski slawekjaranowski force-pushed the repo-layout-maven-repository branch from 1d01e2d to ff6e032 Compare November 28, 2025 07:29
@cstamas
Copy link
Member

cstamas commented Nov 28, 2025

Does this fix the Tycho issue? or is unrelated?

@slawekjaranowski
Copy link
Member Author

Does this fix the Tycho issue? or is unrelated?

Fix Tycho issue - confirmed by test provided in issue

@slawekjaranowski
Copy link
Member Author

Tycho use own repo layouts like:

 <repositories>
    <repository>
      <id>eclipse</id>
      <name>eclipse</name>
      <url>https://download.eclipse.org/releases/2025-03</url>
      <layout>p2</layout>
    </repository> 
  </repositories> 

so we can not override it be default

@cstamas
Copy link
Member

cstamas commented Nov 28, 2025

Of course, I just wanted to make sure does this fix Tycho. @laeubi

@laeubi
Copy link
Contributor

laeubi commented Nov 29, 2025

@slawekjaranowski thanks for looking into this 👍

I wonder if there is a good way to let Tycho test maven snapshots? I think we have had a job in the past but it was deleted because it was broken once in a while, but maybe in the meantime there are better ways to fetching snapshots?

@slawekjaranowski
Copy link
Member Author

@slawekjaranowski thanks for looking into this 👍

I wonder if there is a good way to let Tycho test maven snapshots? I think we have had a job in the past but it was deleted because it was broken once in a while, but maybe in the meantime there are better ways to fetching snapshots?

Snapshot are published to https://repository.apache.org/ so is only one palce to fetch

@slawekjaranowski slawekjaranowski merged commit f49091e into apache:maven-3.9.x Nov 29, 2025
18 checks passed
@slawekjaranowski slawekjaranowski deleted the repo-layout-maven-repository branch November 29, 2025 11:23
@github-actions github-actions bot added this to the 3.9.12 milestone Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.9.12 nightly breaks Tycho Maven plugin

5 participants