Skip to content

values not being respect in values.yaml file #784

Open
@zyue110026

Description

@zyue110026

We have noticed five instances of incorrect helming in your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

grafana.imagePullPolicy, elasticsearch.service.type, elasticsearch.service.nodePort, elasticsearch.service.loadBalancerIP, and elasticsearch.service.loadBalancerSourceRanges are not take affect when change their values to others. This is due to missing implementation for this value in grafana-pod.yaml file:

image: "{{- .Values.docker.registry.name -}}{{- .Values.grafana.imageName -}}:{{- .Values.grafana.imageTag -}}"

and elasticsearch-svc.yaml:

spec:
clusterIP: None # This is needed for statefulset hostnames like elasticsearch-0 to resolve
# Create endpoints also if the related pod isn't ready
publishNotReadyAddresses: true
selector:
name: {{ .Release.Name }}-elasticsearch

Expected Behavior

These values should take affect when changing them or delete them from values.yaml file

Actual Behavior

All values mentioned in this issue are not being respect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions