Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically delete a feed that reaches max trigger count #86

Open
rabbah opened this issue Aug 27, 2017 · 6 comments
Open

automatically delete a feed that reaches max trigger count #86

rabbah opened this issue Aug 27, 2017 · 6 comments

Comments

@rabbah
Copy link
Member

rabbah commented Aug 27, 2017

once a feed has exhausted its triggers, should be deleted for convenience?
it might also be nice to infer which triggers are one offs as well and delete them regardless of max trigger since they will not fire again.

@mbehrendt
Copy link

if we delete the feed -- where will the user see a record making transparent that this happened?

@rabbah
Copy link
Member Author

rabbah commented Aug 27, 2017

The feed API does not provide any visibility into the status of the feed as it is and this opaqueness should be addressed systematically - at which point, the feed API can provide the necessary details: feed deleted in this case or doesn't exist.

See for example: apache/openwhisk-package-kafka#53 but this is not specific to kafka - when a feed fails to fire a trigger, a user has no idea why. Similarly short of counting received triggers activations, the user has no idea how many events were received either, or if the feed is still active (because it already reached max triggers).

@mbehrendt
Copy link

thank you, that's what I thought.

Should we extend the feed API correspondingly?

@jasonpet
Copy link
Contributor

Originally, it was deleted for convenience. Had a request to never delete trigger feed and only disable them. We need to discuss this further and not just keep going back and forth on this matter.

@jberstler
Copy link

Another problem with deleting the feed is that the trigger still exists in the core system, which is likely confusing, as well as being a dangling reference. I think opening up the state of feeds to the user is a better approach than automatically deleting the feed.

@jthomas
Copy link
Member

jthomas commented Oct 19, 2017

It would be nice to support a parameter for choosing whether to "delete when finished". I can see examples where you would want both types of behaviour. It would be better to "opt-in" for this as I can see users getting confused if it defaults to on.

👍 on extending the feed API as well. There have been numerous issues asking for this.
apache/openwhisk#1925
apache/openwhisk#1398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants