Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.javadsl.MqttFlowTest: bidirectional connection may leak actors #468

Open
raboof opened this issue Feb 9, 2024 · 3 comments · May be fixed by #981
Open

docs.javadsl.MqttFlowTest: bidirectional connection may leak actors #468

raboof opened this issue Feb 9, 2024 · 3 comments · May be fixed by #981
Labels
flaky test mqtt-streaming the mqtt-streaming component

Comments

@raboof
Copy link
Member

raboof commented Feb 9, 2024

It seems to be specifically establishClientBidirectionalConnectionAndSubscribeToATopic and establishServerBidirectionalConnectionAndSubscribeToATopic

@raboof raboof added mqtt-streaming the mqtt-streaming component flaky test labels Feb 9, 2024
@raboof raboof changed the title docs.javadsl.MqttFlowTest: leaks actors docs.javadsl.MqttFlowTest: bidirectional connection may leak actors Jul 7, 2024
raboof added a commit to raboof/incubator-pekko-connectors that referenced this issue Jul 7, 2024
While looking into apache#468, I noticed the two failing tests were
sharing the same session id, which reminded of apache#456.

While in this case the two tests aren't sharing the same
session, and I haven't investigated the details of this
codebase further, I'm curious to see if the problem remains
when we use unique session ids.
raboof added a commit to raboof/incubator-pekko-connectors that referenced this issue Jul 7, 2024
While looking into apache#468, I noticed the two failing tests were
sharing the same session id, which reminded of apache#456.

While in this case the two tests aren't sharing the same
session, and I haven't investigated the details of this
codebase further, I'm curious to see if the problem remains
when we use unique session ids.
raboof added a commit that referenced this issue Jul 7, 2024
While looking into #468, I noticed the two failing tests were
sharing the same session id, which reminded of #456.

While in this case the two tests aren't sharing the same
session, and I haven't investigated the details of this
codebase further, I'm curious to see if the problem remains
when we use unique session ids.
raboof added a commit to raboof/incubator-pekko-connectors that referenced this issue Jul 8, 2024
Roiocam pushed a commit that referenced this issue Jul 11, 2024
@raboof
Copy link
Member Author

raboof commented Jul 11, 2024

(let's close this for now in case #736 was it, and re-open when it turns out it wasn't)

@raboof raboof closed this as completed Jul 11, 2024
@raboof
Copy link
Member Author

raboof commented Jul 11, 2024

@raboof raboof reopened this Jul 11, 2024
raboof added a commit to raboof/incubator-pekko-connectors that referenced this issue Feb 9, 2025
Avoid multiple tests using the same topic.

Possibly towards avoiding apache#468
@raboof raboof linked a pull request Feb 9, 2025 that will close this issue
@raboof
Copy link
Member Author

raboof commented Feb 9, 2025

The problem is that, after the test finishes, there are still Streams components 'in flight', indicating some kind of leak in the stream teardown logic.

The component that checks for these remaining running components helpfully products 'dot' graphs to diagnose what is waiting for what. Unfortunately these confuse me even more: it seems even 'headSink' is still waiting for input, even though that component should complete after producing its one and only value (and the test completing suggests that this has already happened). That could use additional research: is the component indeed still running, or is the dot output just confusing?

However, while looking at this test again, I noticed that it is still using a topic that is also used in another test. While that doesn't really explain why the components still seem to be running after the test has completed, no good can come of it, so let's make sure those tests are independent with #981.

Of course multiple tests sharing the same topic should still not lead to stream components getting left behind - but if making the tests more independent fixes the symptom of these flaky tests that's already a win in my book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test mqtt-streaming the mqtt-streaming component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant