Skip to content

Commit 8d478b7

Browse files
committed
review
1 parent 724fd32 commit 8d478b7

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

helm/polaris/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ weight: 675
2828
Do not modify the README.md file directly, please modify README.md.gotmpl instead.
2929
To re-generate the README.md file, install helm-docs then run from the repo root:
3030
helm-docs --chart-search-root=helm
31-
Alternatively, run ./gradlew helmDocs from the repo root.
31+
Alternatively, run `./gradlew helmDocs` or `make helm-doc-generate` from the repo root.
3232
-->
3333

3434
![Version: 1.2.0-incubating-SNAPSHOT](https://img.shields.io/badge/Version-1.2.0--incubating--SNAPSHOT-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.2.0-incubating-SNAPSHOT](https://img.shields.io/badge/AppVersion-1.2.0--incubating--SNAPSHOT-informational?style=flat-square)
@@ -183,7 +183,7 @@ Integration tests are run with the Chart Testing tool:
183183
ct install --namespace polaris --charts ./helm/polaris
184184
```
185185

186-
### Running tets with Gradle
186+
### Running tests with Gradle
187187

188188
Both unit and integration tests can be run with Gradle. From the Polaris repo root:
189189

helm/polaris/README.md.gotmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ weight: 675
2828
Do not modify the README.md file directly, please modify README.md.gotmpl instead.
2929
To re-generate the README.md file, install helm-docs then run from the repo root:
3030
helm-docs --chart-search-root=helm
31-
Alternatively, run ./gradlew helmDocs from the repo root.
31+
Alternatively, run `./gradlew helmDocs` or `make helm-doc-generate` from the repo root.
3232
-->
3333

3434
{{ template "chart.deprecationWarning" . }}
@@ -185,7 +185,7 @@ Integration tests are run with the Chart Testing tool:
185185
ct install --namespace polaris --charts ./helm/polaris
186186
```
187187

188-
### Running tets with Gradle
188+
### Running tests with Gradle
189189

190190
Both unit and integration tests can be run with Gradle. From the Polaris repo root:
191191

site/content/in-dev/unreleased/helm.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ weight: 675
2828
Do not modify the README.md file directly, please modify README.md.gotmpl instead.
2929
To re-generate the README.md file, install helm-docs then run from the repo root:
3030
helm-docs --chart-search-root=helm
31-
Alternatively, run ./gradlew helmDocs from the repo root.
31+
Alternatively, run `./gradlew helmDocs` or `make helm-doc-generate` from the repo root.
3232
-->
3333

3434
![Version: 1.2.0-incubating-SNAPSHOT](https://img.shields.io/badge/Version-1.2.0--incubating--SNAPSHOT-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.2.0-incubating-SNAPSHOT](https://img.shields.io/badge/AppVersion-1.2.0--incubating--SNAPSHOT-informational?style=flat-square)
@@ -185,7 +185,7 @@ Integration tests are run with the Chart Testing tool:
185185
ct install --namespace polaris --charts ./helm/polaris
186186
```
187187

188-
### Running tets with Gradle
188+
### Running tests with Gradle
189189

190190
Both unit and integration tests can be run with Gradle. From the Polaris repo root:
191191

@@ -321,6 +321,11 @@ Both unit and integration tests can be run with Gradle. From the Polaris repo ro
321321
| persistence.relationalJdbc.secret.username | string | `"username"` | The secret key holding the database username for authentication |
322322
| persistence.type | string | `"in-memory"` | The type of persistence to use. Two built-in types are supported: in-memory and relational-jdbc. The eclipse-link type is also supported but is deprecated. |
323323
| podAnnotations | object | `{}` | Annotations to apply to polaris pods. |
324+
| podDisruptionBudget | object | `{"annotations":{},"enabled":false,"maxUnavailable":null,"minAvailable":null}` | Pod disruption budget settings. |
325+
| podDisruptionBudget.annotations | object | `{}` | Annotations to add to the pod disruption budget. |
326+
| podDisruptionBudget.enabled | bool | `false` | Specifies whether a pod disruption budget should be created. |
327+
| podDisruptionBudget.maxUnavailable | string | `nil` | The maximum number of pods that can be unavailable during disruptions. Can be an absolute number (ex: 5) or a percentage of desired pods (ex: 50%). IMPORTANT: Cannot be used simultaneously with minAvailable. |
328+
| podDisruptionBudget.minAvailable | string | `nil` | The minimum number of pods that should remain available during disruptions. Can be an absolute number (ex: 5) or a percentage of desired pods (ex: 50%). IMPORTANT: Cannot be used simultaneously with maxUnavailable. |
324329
| podLabels | object | `{}` | Additional Labels to apply to polaris pods. |
325330
| podSecurityContext | object | `{"fsGroup":10001,"seccompProfile":{"type":"RuntimeDefault"}}` | Security context for the polaris pod. See https://kubernetes.io/docs/tasks/configure-pod-container/security-context/. |
326331
| podSecurityContext.fsGroup | int | `10001` | GID 10001 is compatible with Polaris OSS default images; change this if you are using a different image. |

0 commit comments

Comments
 (0)