Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly expensive resource utilization via object-storage (and related) clients #564

Open
snazy opened this issue Dec 16, 2024 · 2 comments
Labels
1.0-blocker bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@snazy
Copy link
Member

snazy commented Dec 16, 2024

Describe the bug

Instances of object-storage (e.g. S3Client) and credential-vending clients (e.g. StsClient) are "fully" created for every client request. This means, that also implicit resources like HTTP connection pools and thread pools are created for every client request. This is too expensive.

Related to #563

@snazy snazy added the bug Something isn't working label Dec 16, 2024
@flyrain flyrain added this to the 1.0.0 milestone Mar 13, 2025
@flyrain
Copy link
Contributor

flyrain commented Mar 13, 2025

Thanks for reporting this. It'd be a nice improvement. I will mark it as a 1.0.0 milestone, while removing it as a 1.0 blocker.

@flyrain flyrain added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working 1.0-blocker labels Mar 13, 2025
@snazy snazy added bug Something isn't working 1.0-blocker and removed enhancement New feature or request labels Mar 17, 2025
@snazy
Copy link
Member Author

snazy commented Mar 17, 2025

@flyrain re-creating HTTP connections and thread pools is a completely unnecessary waste of system resources, without guarantees that these system resources are properly released, risking system stability. So the labels you've removed are IMHO justified, so I'm re-adding those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0-blocker bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants