Confusing log messages about POLARIS_SEQ
#621
Comments
|
Sorry, what are you confused by? |
|
Because there is no "legacy" in Polaris - and that message implies that there's something missing. TL;DR the message is not useful for users, right? |
|
What do you mean by “there is no legacy”?
…On Fri, Jan 10, 2025 at 10:56 PM Robert Stupp ***@***.***> wrote:
Because there is no "legacy" in Polaris - and that message implies that
there's something missing. TL;DR the message is not useful for users, right?
—
Reply to this email directly, view it on GitHub
<#621 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFRE3SHLL4YI5LERB7RBGUT2KC6DJAVCNFSM6AAAAABUXKPDX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVGEZDIMRVGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
There's no Polaris release yet, no? |
|
Also, what can or should a user do when he sees those messages? |
Be aware of what entity in the backend is being used.
I'm not sure I follow you here. The message doesn't refer to any version. |
@eric-maynard the term "legacy" is used in the Javadoc: "If the legacy |
|
I can see the Javadoc, but I don't see what you're confused by. |
|
Are you saying that you think "legacy" usually is an identifier used to refer to a particular version of software? It is not. |
|
In this case it does. Again, there is no "POLARIS_SEQ legacy" in this code base, so the whole thing can and should go away. It is confusing. |
|
No, in this case it actually doesn't. Maybe that's the source of confusion here? Older "versions" of Polaris used this entity POLARIS_SEQ, but it isn't used by newer "versions". It is a sort of vestigial entity that may be used one-time to continue the sequence, and legacy is used in that sense. Is there another term that you think we should use which would be more clear? |
|
The whole point is that a) the logging is confusing and the "legacy" is not properly defined. But still, I cannot find any usage of |
|
Yes -- if POLARIS_SEQ (removed here) was used in a release then I would prefer this comment to say something like: But since there isn't a version, "legacy" was the most descriptive term I could think of. The generator is legacy in that it may still be around in the metastore but should only be used in a one-off operation and otherwise is disused now. Eventually I think we can even clean a lot of this up. That is, remove the logging and a lot of the code. We just needed this to make sure we didn't break any existing deployments using the old (legacy) metastore implementation. The idea was to wait to ensure nobody was still relying on POLARIS_SEQ before ripping this code out. That may be the case by now. |
|
TBH: since there is no Polaris release yet, there is nothing to care about. I'll start a dev-ML discussion about this. |
Describe the bug
The log messages
are just confusing - the code mentions "legacy", but there is no "legacy" in Polaris.
To Reproduce
No response
Actual Behavior
No response
Expected Behavior
No response
Additional context
No response
System information
No response
The text was updated successfully, but these errors were encountered: