Skip to content

Commit 2b22b90

Browse files
authored
Update RangerServiceService.java
1 parent af740b7 commit 2b22b90

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -88,18 +88,14 @@ public Map<String, String> getConfigsWithDecryptedPassword(RangerService service
8888
String freeTextPasswordMetaData = Joiner.on(",").skipNulls().join(util.getCryptAlgo(), new String(util.getEncryptKey()), new String(util.getSalt()), util.getIterationCount(), PasswordUtils.needsIv(util.getCryptAlgo()) ? util.getIvAsString() : null);
8989
String decryptedPwd = PasswordUtils.decryptPassword(encryptedPwd);
9090
if (StringUtils.equalsIgnoreCase(freeTextPasswordMetaData + "," + PasswordUtils.encryptPassword(freeTextPasswordMetaData + "," + decryptedPwd), encryptedPwd)) {
91-
configs.put(ServiceDBStore.CONFIG_KEY_PASSWORD, encryptedPwd); // XXX: method name is
92-
// getConfigsWithDecryptedPassword,
93-
// then why do we store the
94-
// encryptedPwd?
91+
configs.put(ServiceDBStore.CONFIG_KEY_PASSWORD, encryptedPwd);
92+
// XXX: method name is getConfigsWithDecryptedPassword, then why do we store the encryptedPwd?
9593
}
9694
} else {
9795
String decryptedPwd = PasswordUtils.decryptPassword(encryptedPwd);
9896
if (StringUtils.equalsIgnoreCase(PasswordUtils.encryptPassword(decryptedPwd), encryptedPwd)) {
99-
configs.put(ServiceDBStore.CONFIG_KEY_PASSWORD, encryptedPwd); // XXX: method name is
100-
// getConfigsWithDecryptedPassword,
101-
// then why do we store the
102-
// encryptedPwd?
97+
configs.put(ServiceDBStore.CONFIG_KEY_PASSWORD, encryptedPwd);
98+
// XXX: method name is getConfigsWithDecryptedPassword, then why do we store the encryptedPwd?
10399
}
104100
}
105101
}
@@ -149,7 +145,6 @@ protected RangerService populateViewBean(XXService xService) {
149145

150146
@Override
151147
protected void validateForCreate(RangerService vObj) {
152-
// TODO Auto-generated method stub
153148
}
154149

155150
@Override

0 commit comments

Comments
 (0)