update comments and documentaiton

Author: traeak

include/proxy/http/remap/RemapConfig.h

@@ -77,7 +77,7 @@ struct BUILD_TABLE_INFO {
   BUILD_TABLE_INFO(const BUILD_TABLE_INFO &)            = delete; // disabled
   BUILD_TABLE_INFO &operator=(const BUILD_TABLE_INFO &) = delete; // disabled
 
-  // This is used to expose rewrite and its next hop strategy factory.
+  // Exposes the main build table to the API for use during TSRemapNewInstance.
   inline static BUILD_TABLE_INFO *instance = nullptr;
 };
 

include/ts/ts.h

@@ -1619,10 +1619,10 @@ char const *TSHttpNextHopStrategyNameGet(void const *strategy);
 /**
     Retrieves a pointer to the named strategy in the strategy table.
                 This can only be called during TSRemapNewInstance.
-    Returns nullptr if no strategy found.
-    This uses the current RemapInit NextHopStrategyFactory.
+                                                                DO NOT FREE.
 
-                This strategy pointer can still be used by all following transactions.
+    Returns nullptr if no strategy found.
+    This uses the currently being loaded RemapConfig NextHopStrategyFactory.
 
     @param name of the strategy to look up.
 

src/api/InkAPI.cc

@@ -5051,13 +5051,14 @@ TSHttpInitNextHopNamedStrategyGet(const char *name)
 
   sdk_assert(sdk_sanity_check_null_ptr((void *)bt) == TS_SUCCESS);
   sdk_assert(sdk_sanity_check_null_ptr((void *)bt->rewrite) == TS_SUCCESS);
-  sdk_assert(sdk_sanity_check_null_ptr((void *)bt->rewrite->strategyFactory) == TS_SUCCESS);
 
-  // HttpSM has a reference count handle to UrlRewrite which has a
-  // pointer to NextHopStrategyFactory
-  NextHopSelectionStrategy const *const strat = bt->rewrite->strategyFactory->strategyInstance(name);
+  NextHopSelectionStrategy const *strat = nullptr;
 
-  fprintf(stderr, "strategy: %s, ptr: %p\n", name, (void *)strat);
+  if (nullptr != bt->rewrite->strategyFactory) {
+    // HttpSM has a reference count handle to UrlRewrite which manages
+    // the NextHopStrategyFactory pointer.
+    strat = bt->rewrite->strategyFactory->strategyInstance(name);
+  }
 
   return static_cast<void const *>(strat);
 }