Skip to content

Commit eb2e03e

Browse files
authored
[ZEPPELIN-6255] added message in the create-repository-modal for user not to be confused
…g a repository with an existing ID will update the existing repository ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html - Currently, users can update the configuration of a registered repository used for dependency resolution by creating a new entry with the same ID under Add New Repository, but with different settings. However, this behavior is not intuitive, and users may not realize that modifying an existing repository is possible in this way. To improve clarity, we’ve added a simple explanation to the Interpreter page UI, informing users that creating a repository with an existing ID will update the existing configuration rather than creating a new one. Alternatively, in the future, it may be worth considering implementing a dedicated Edit Repository feature, along with an option to Remove Repository, to make this workflow even clearer. ### What type of PR is it? Bug Fix Improvement Feature Documentation Hot Fix Refactoring *Please leave your type of PR only* - Improvement ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] - [ZEPPELIN-6255] ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) <img width="789" height="680" alt="image" src="https://github.com/user-attachments/assets/f1f3481e-1cdb-4757-bfec-25bab2944060" /> ### Questions: * Does the license files need to update? * Is there breaking changes for older versions? * Does this needs documentation? Closes #5011 from yunajoe/feature/6255. Signed-off-by: Jongyoul Lee <[email protected]>
1 parent d4072a6 commit eb2e03e

File tree

4 files changed

+18
-57
lines changed

4 files changed

+18
-57
lines changed

zeppelin-web-angular/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ Thumbs.db
4444

4545
#
4646
.env
47-
yarn.lock
47+
yarn.lock

zeppelin-web-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,4 +99,4 @@
9999
"pre-commit": "lint-staged"
100100
}
101101
}
102-
}
102+
}

zeppelin-web-angular/proxy.conf.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ const proxyConfig = [
2525
context: '/ws',
2626
target: 'ws://localhost:8080',
2727
secure: false,
28-
ws:true,
28+
ws: true,
2929
changeOrigin: true
3030
}
3131
];
3232

3333
function httpUrlToWSUrl(url) {
34-
return url.replace(/(http)(s)?\:\/\//, "ws$2://");
34+
return url.replace(/(http)(s)?\:\/\//, 'ws$2://');
3535
}
3636

3737
function setupForCorporateProxy(proxyConfig) {
@@ -44,7 +44,7 @@ function setupForCorporateProxy(proxyConfig) {
4444
}
4545
proxyConfig.forEach(function(entry) {
4646
if (entry.context === '/ws') {
47-
entry.target = httpUrlToWSUrl(proxyServer)
47+
entry.target = httpUrlToWSUrl(proxyServer);
4848
} else {
4949
entry.target = proxyServer;
5050
}

zeppelin-web-angular/src/app/pages/workspace/interpreter/create-repository-modal/create-repository-modal.component.html

Lines changed: 13 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,15 @@
1111
-->
1212

1313
<form nz-form [nzLayout]="'horizontal'" [formGroup]="validateForm" (ngSubmit)="handleSubmit()">
14+
<p style="color: #1890ff; font-size: 12px;">
15+
Adding a repository with an existing ID will update the existing repository.
16+
</p>
1417
<nz-form-item>
1518
<nz-form-label [nzSpan]="6" nzRequired>
1619
ID
1720
</nz-form-label>
1821
<nz-form-control nz-col [nzSpan]="16">
19-
<input
20-
nz-input
21-
autofocus
22-
formControlName="id"
23-
placeholder="Repository id"
24-
/>
22+
<input nz-input autofocus formControlName="id" placeholder="Repository id" />
2523
</nz-form-control>
2624
</nz-form-item>
2725
<nz-form-item>
@@ -30,15 +28,10 @@
3028
</nz-form-label>
3129
<nz-form-control nz-col [nzSpan]="16">
3230
<nz-input-group [nzAddOnBefore]="addOnBeforeTemplate">
33-
<input type="text"
34-
nz-input
35-
formControlName="url"
36-
placeholder="Repository url">
31+
<input type="text" nz-input formControlName="url" placeholder="Repository url" />
3732
</nz-input-group>
3833
<ng-template #addOnBeforeTemplate>
39-
<nz-select name="urlProtocol"
40-
[(ngModel)]="urlProtocol"
41-
[ngModelOptions]="{standalone: true}">
34+
<nz-select name="urlProtocol" [(ngModel)]="urlProtocol" [ngModelOptions]="{ standalone: true }">
4235
<nz-option [nzLabel]="'http://'" [nzValue]="'http://'"></nz-option>
4336
<nz-option [nzLabel]="'https://'" [nzValue]="'https://'"></nz-option>
4437
<nz-option [nzLabel]="'file://'" [nzValue]="'file://'"></nz-option>
@@ -59,24 +52,15 @@
5952
Username
6053
</nz-form-label>
6154
<nz-form-control nz-col [nzSpan]="16">
62-
<input
63-
nz-input
64-
formControlName="username"
65-
placeholder="username"
66-
/>
55+
<input nz-input formControlName="username" placeholder="username" />
6756
</nz-form-control>
6857
</nz-form-item>
6958
<nz-form-item>
7059
<nz-form-label [nzSpan]="6">
7160
Password
7261
</nz-form-label>
7362
<nz-form-control nz-col [nzSpan]="16">
74-
<input
75-
nz-input
76-
type="password"
77-
formControlName="password"
78-
placeholder="password"
79-
/>
63+
<input nz-input type="password" formControlName="password" placeholder="password" />
8064
</nz-form-control>
8165
</nz-form-item>
8266
<nz-divider nzType="horizontal"></nz-divider>
@@ -96,60 +80,37 @@
9680
Host
9781
</nz-form-label>
9882
<nz-form-control nz-col [nzSpan]="16">
99-
<input
100-
nz-input
101-
formControlName="proxyHost"
102-
placeholder="proxy host"
103-
/>
83+
<input nz-input formControlName="proxyHost" placeholder="proxy host" />
10484
</nz-form-control>
10585
</nz-form-item>
10686
<nz-form-item>
10787
<nz-form-label [nzSpan]="6">
10888
Port
10989
</nz-form-label>
11090
<nz-form-control nz-col [nzSpan]="16">
111-
<input
112-
nz-input
113-
formControlName="proxyPort"
114-
placeholder="proxy port"
115-
/>
91+
<input nz-input formControlName="proxyPort" placeholder="proxy port" />
11692
</nz-form-control>
11793
</nz-form-item>
11894
<nz-form-item>
11995
<nz-form-label [nzSpan]="6">
12096
Login
12197
</nz-form-label>
12298
<nz-form-control nz-col [nzSpan]="16">
123-
<input
124-
nz-input
125-
formControlName="proxyLogin"
126-
placeholder="proxy login"
127-
/>
99+
<input nz-input formControlName="proxyLogin" placeholder="proxy login" />
128100
</nz-form-control>
129101
</nz-form-item>
130102
<nz-form-item>
131103
<nz-form-label [nzSpan]="6">
132104
Password
133105
</nz-form-label>
134106
<nz-form-control nz-col [nzSpan]="16">
135-
<input
136-
nz-input
137-
type="password"
138-
formControlName="proxyLogin"
139-
placeholder="proxy password"
140-
/>
107+
<input nz-input type="password" formControlName="proxyLogin" placeholder="proxy password" />
141108
</nz-form-control>
142109
</nz-form-item>
143110
</form>
144111

145112
<div class="modal-footer ant-modal-footer">
146-
<button
147-
nz-button
148-
nzType="primary"
149-
[disabled]="!validateForm.valid"
150-
(click)="handleSubmit()"
151-
[nzLoading]="submitting"
152-
>
113+
<button nz-button nzType="primary" [disabled]="!validateForm.valid" (click)="handleSubmit()" [nzLoading]="submitting">
153114
Add
154115
</button>
155116
<button nz-button (click)="handleCancel()">

0 commit comments

Comments
 (0)