Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate consistency between thermal models #20

Open
daniellengyel opened this issue Jul 18, 2018 · 1 comment
Open

Evaluate consistency between thermal models #20

daniellengyel opened this issue Jul 18, 2018 · 1 comment

Comments

@daniellengyel
Copy link
Collaborator

For now, i will not use a thermal model if it is not consistent or sensible for any of the actions.

Might want to consider other possibilities. such as taking the maximum temperature increase across all actions and assign it to heating, etc.

Currently, this example is a problem:

Standard Thermal Model:
cooling = -0.2
doing nothing = 0.1
heating = 50

Average Model:
cooling = -0.2
doing nothing = 0.00001
heating= nan

constant model:
cooling= - 0.05
doing nothing = 0
heating = 0.05

The MPC will disregard the heating of the standard thermal model because it is not sensible, and will assign the constant 0.05 heating. however, the doing_nothing of the standard model is consistent and will hence be used . However, now heating and doing nothing are inconsistent.

@daniellengyel
Copy link
Collaborator Author

Implemented the ability to just disregard any prediction if any of the other actions are not sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant