fix: Remove deprecated spider arg from pipeline process_item methods

Scrapy 2.14+ deprecated the spider argument in process_item() and newer
versions no longer pass it, causing TypeError in PriceCleanerPipeline.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: vdusek

src/apify/scrapy/pipelines/actor_dataset_push.py

@@ -8,7 +8,7 @@
 from apify import Actor
 
 if TYPE_CHECKING:
-    from scrapy import Item, Spider
+    from scrapy import Item
 
 logger = getLogger(__name__)
 
@@ -22,10 +22,9 @@ class ActorDatasetPushPipeline:
     async def process_item(
         self,
         item: Item,
-        spider: Spider,
     ) -> Item:
         """Pushes the provided Scrapy item to the Actor's default dataset."""
         item_dict = ItemAdapter(item).asdict()
-        logger.debug(f'Pushing item={item_dict} produced by spider={spider} to the dataset.')
+        logger.debug(f'Pushing item={item_dict} to the dataset.')
         await Actor.push_data(item_dict)
         return item

tests/e2e/test_scrapy/actor_source/pipelines.py

@@ -3,14 +3,13 @@
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
-    from scrapy import Item, Spider
+    from scrapy import Item
 
 
 class PriceCleanerPipeline:
     def process_item(
         self,
         item: Item,
-        _: Spider,
     ) -> Item:
         if 'price' in item and isinstance(item['price'], str):
             item['price'] = item['price'].lstrip('$')

tests/unit/scrapy/pipelines/test_actor_dataset_push.py

@@ -3,16 +3,12 @@
 from dataclasses import dataclass
 
 import pytest
-from scrapy import Field, Item, Spider
+from scrapy import Field, Item
 
 from apify import Actor
 from apify.scrapy.pipelines import ActorDatasetPushPipeline
 
 
-class DummySpider(Spider):
-    name = 'dummy_spider'
-
-
 class DummyItem(Item):
     a = Field()
     b = Field()
@@ -24,12 +20,6 @@ class TitleItem(Item):
     title = Field()
 
 
-@pytest.fixture
-def spider() -> DummySpider:
-    """Fixture to create a "dummy" Scrapy spider."""
-    return DummySpider()
-
-
 @pytest.fixture
 def pipeline() -> ActorDatasetPushPipeline:
     """Fixture to create an Actor dataset push pipeline."""
@@ -67,7 +57,6 @@ class ItemTestCase:
 async def test_process_item(
     monkeypatch: pytest.MonkeyPatch,
     pipeline: ActorDatasetPushPipeline,
-    spider: Spider,
     tc: ItemTestCase,
 ) -> None:
     dataset = []
@@ -79,9 +68,9 @@ async def mock_push_data(item: dict) -> None:
 
     if tc.expected_exception:
         with pytest.raises(tc.expected_exception):
-            await pipeline.process_item(tc.item, spider)
+            await pipeline.process_item(tc.item)
 
     else:
-        output = await pipeline.process_item(tc.item, spider)
+        output = await pipeline.process_item(tc.item)
         assert output == tc.item
         assert dataset == [tc.item_dict]