From b3d17af8dc8050281e104324b46d6cacd604fb08 Mon Sep 17 00:00:00 2001
From: Nicole Stock <nicole.stock@jhuapl.edu>
Date: Fri, 9 May 2025 10:32:51 -0400
Subject: [PATCH 1/2] Fix broken numbered docs links. Replace hardcoded url
 with constant

---
 web/src/components/DandiFooter.vue                        | 5 +++--
 web/src/components/FileBrowser/FileUploadInstructions.vue | 3 ++-
 web/src/views/CreateDandisetView/CreateDandisetView.vue   | 4 ++--
 web/src/views/DandisetLandingView/DownloadDialog.vue      | 3 ++-
 4 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/web/src/components/DandiFooter.vue b/web/src/components/DandiFooter.vue
index ead11db79..2c4318ded 100644
--- a/web/src/components/DandiFooter.vue
+++ b/web/src/components/DandiFooter.vue
@@ -8,14 +8,14 @@
           <a
             target="_blank"
             rel="noopener"
-            href="https://docs.dandiarchive.org/about/terms/"
+            :href="`${dandiDocumentationUrl}/about/terms/`"
           >Terms</a>
           <v-icon size="x-small">
             mdi-open-in-new
           </v-icon> / <a
             target="_blank"
             rel="noopener"
-            href="https://docs.dandiarchive.org/about/policies/"
+            :href="`${dandiDocumentationUrl}/about/policies/`"
           >Policies</a>
           <v-icon size="x-small">
             mdi-open-in-new
@@ -99,6 +99,7 @@
 
 <script setup lang="ts">
 import CookieBanner from './CookieBanner.vue';
+import { dandiDocumentationUrl } from '@/utils/constants';
 
 const version = import.meta.env.VITE_APP_VERSION;
 const githubLink = import.meta.env.VITE_APP_GIT_REVISION ? `https://github.com/dandi/dandi-archive/commit/${import.meta.env.VITE_APP_GIT_REVISION}` : 'https://github.com/dandi/dandi-archive';
diff --git a/web/src/components/FileBrowser/FileUploadInstructions.vue b/web/src/components/FileBrowser/FileUploadInstructions.vue
index fff0d09f5..2d69117ac 100644
--- a/web/src/components/FileBrowser/FileUploadInstructions.vue
+++ b/web/src/components/FileBrowser/FileUploadInstructions.vue
@@ -36,7 +36,7 @@
           <span class="text-body-2 text-grey-darken-1">
             <span class="text-body-2 text-grey-darken-1">
               Follow the installation instructions in the
-              <a href="https://docs.dandiarchive.org/user-guide-sharing/uploading-data">
+              <a :href="`${dandiDocumentationUrl}/user-guide-sharing/uploading-data`">
                 DANDI Docs
               </a> .
             </span>
@@ -50,6 +50,7 @@
 <script setup lang="ts">
 import { computed } from 'vue';
 import { useDandisetStore } from '@/stores/dandiset';
+import { dandiDocumentationUrl } from '@/utils/constants';
 
 const store = useDandisetStore();
 const dandisetIdentifier = computed(() => store.dandiset?.dandiset.identifier);
diff --git a/web/src/views/CreateDandisetView/CreateDandisetView.vue b/web/src/views/CreateDandisetView/CreateDandisetView.vue
index 15a591263..db31bc10b 100644
--- a/web/src/views/CreateDandisetView/CreateDandisetView.vue
+++ b/web/src/views/CreateDandisetView/CreateDandisetView.vue
@@ -95,7 +95,7 @@
           <div>
             Select a license under which to share the contents of this Dandiset.
             You can learn more about <a
-              href="https://docs.dandiarchive.org/35_data_licenses/"
+              :href="`${dandiDocumentationUrl}/user-guide-sharing/data-licenses`"
               target="_blank"
               rel="noopener"
             >
@@ -158,7 +158,7 @@ import { useRouter } from 'vue-router';
 import type { ComputedRef } from 'vue';
 import { dandiRest, loggedIn } from '@/rest';
 import { useDandisetStore } from '@/stores/dandiset';
-import { sandboxDocsUrl } from '@/utils/constants';
+import { dandiDocumentationUrl, sandboxDocsUrl } from '@/utils/constants';
 
 import type { IdentifierForAnAward, LicenseType, License } from '@/types';
 
diff --git a/web/src/views/DandisetLandingView/DownloadDialog.vue b/web/src/views/DandisetLandingView/DownloadDialog.vue
index ead114e03..3d4b76833 100644
--- a/web/src/views/DandisetLandingView/DownloadDialog.vue
+++ b/web/src/views/DandisetLandingView/DownloadDialog.vue
@@ -36,7 +36,7 @@
         <v-tooltip location="right">
           <template #activator="{ props }">
             <v-btn
-              href="https://docs.dandiarchive.org/12_download/"
+              :href="`${dandiDocumentationUrl}/user-guide-using/accessing-data/downloading`"
               target="_blank"
               rel="noopener"
               variant="text"
@@ -136,6 +136,7 @@
 import { computed, ref } from 'vue';
 import { useDandisetStore } from '@/stores/dandiset';
 import CopyText from '@/components/CopyText.vue';
+import { dandiDocumentationUrl } from '@/utils/constants';
 
 function downloadCommand(identifier: string, version: string): string {
   // Use the special 'DANDI:' url prefix if appropriate.

From de2738d7cdadd782d0cd543b368f8e2afcec2e3b Mon Sep 17 00:00:00 2001
From: Nicole Stock <nicole.stock@jhuapl.edu>
Date: Fri, 9 May 2025 10:41:48 -0400
Subject: [PATCH 2/2] Distinguish between ember and dandi documentation links

---
 web/src/components/AppBar/AppBar.vue | 4 ++--
 web/src/utils/constants.ts           | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/web/src/components/AppBar/AppBar.vue b/web/src/components/AppBar/AppBar.vue
index 6d1ff6a0d..b3b9d7ae4 100644
--- a/web/src/components/AppBar/AppBar.vue
+++ b/web/src/components/AppBar/AppBar.vue
@@ -140,7 +140,7 @@ import {
   user,
 } from '@/rest';
 import {
-  emberAboutUrl, dandiDocumentationUrl,
+  emberAboutUrl, emberDocumentationUrl,
 } from '@/utils/constants';
 import UserMenu from '@/components/AppBar/UserMenu.vue';
 import logo from '@/assets/ember-logo.png';
@@ -184,7 +184,7 @@ const navItems: NavigationItem[] = [
   },
   {
     text: 'Documentation',
-    to: dandiDocumentationUrl,
+    to: emberDocumentationUrl,
     external: true,
   },
   // {
diff --git a/web/src/utils/constants.ts b/web/src/utils/constants.ts
index 986129639..aa62b06b2 100644
--- a/web/src/utils/constants.ts
+++ b/web/src/utils/constants.ts
@@ -2,7 +2,8 @@ const dandiUrl = 'https://dandiarchive.org';
 const emberHomeUrl = 'https://emberarchive.org';
 const emberAboutUrl = 'https://emberarchive.org/about';
 const emberGitHubUrl = 'https://github.com/aplbrain/dandi-archive';
-const dandiDocumentationUrl = 'https://emberarchive.org/documentation';
+const emberDocumentationUrl = 'https://emberarchive.org/documentation';
+const dandiDocumentationUrl = 'https://docs.dandiarchive.org/documentation';
 // const dandiAboutUrl = 'https://about.dandiarchive.org/';
 const dandiHelpUrl = 'https://github.com/dandi/helpdesk/issues/new/choose';
 const dandihubUrl = 'https://hub.dandiarchive.org/';
@@ -61,6 +62,7 @@ export {
   emberHomeUrl,
   emberAboutUrl,
   emberGitHubUrl,
+  emberDocumentationUrl,
   dandiDocumentationUrl,
   dandihubUrl,
   sandboxDocsUrl,