Skip to content

Commit a12a0bf

Browse files
arcanisabernix
authored andcommitted
a-e-r: Add missing peer dependency on graphql. (#3496)
* Adds missing peer dependency * Widen `peerDependencies` range to match other Apollo packages' ranges. The `apollo-engine-reporting` package was absolutely missing its `peerDependencies` specification for `graphql`. The previous commit added it, but we also need to expand it to match the same range as suggested by the rest of the Apollo packages in the Apollo Server monorepo. Ref: https://git.io/JeXBd * Add CHANGELOG.md for #3496.
1 parent c63786b commit a12a0bf

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ The version headers in this history reflect the versions of Apollo Server itself
77
> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the the appropriate changes within that release will be moved into the new section.
88
99
- `@apollo/gateway`: Add `@types/node-fetch` as a regular dependency to avoid missing dependency for TypeScript consumers. [PR #3546](https://github.com/apollographql/apollo-server/pull/3546) [Issue #3471](https://github.com/apollographql/apollo-server/issues/3471)
10+
- `apollo-engine-reporting`: Declare acceptable `graphql` versions ranges in `peerDependencies` rather than allowing it to occur implicitly (and less ideally) via its consumers (e.g. most `apollo-server-*` packages). [PR #3496](https://github.com/apollographql/apollo-server/pull/3496)
1011

1112
### v2.9.12
1213

packages/apollo-engine-reporting/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,8 @@
1818
"apollo-server-types": "file:../apollo-server-types",
1919
"async-retry": "^1.2.1",
2020
"graphql-extensions": "file:../graphql-extensions"
21+
},
22+
"peerDependencies": {
23+
"graphql": "^0.12.0 || ^0.13.0 || ^14.0.0"
2124
}
2225
}

0 commit comments

Comments
 (0)