Skip to content

use os functions instead of running exec #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use os functions instead of running exec #34

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6666be
use os functions instead of running exec
jonmosco Feb 1, 2024
70f66b7
use filepath.join for directory concatenation
jonmosco Feb 14, 2024
452b5d5
updates for Drews comments
jonmosco Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions pkg/downloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"
"fmt"
"log"
"os/exec"
"os"
"time"

"github.com/app-sre/git-partition-sync-consumer/pkg/metrics"
Expand Down Expand Up @@ -43,8 +43,7 @@ func NewDownloader(
workdir string,
runOnce bool) (*Downloader, error) {

cmd := exec.Command("mkdir", "-p", workdir)
err := cmd.Run()
err := os.Mkdir(workdir, 0755)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -148,15 +147,12 @@ func (d *Downloader) Run(ctx context.Context, dryRun, runOnce bool) error {

// clean target working directory
func (d *Downloader) clean(directory string) error {
cmd := exec.Command("rm", "-rf", directory)
cmd.Dir = d.workdir
err := cmd.Run()
err := os.RemoveAll(directory)
if err != nil {
return err
}
cmd = exec.Command("mkdir", directory)
cmd.Dir = d.workdir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same filepath change needed here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

452b5d5

err = cmd.Run()

err = os.Mkdir(directory, 0775)
if err != nil {
return err
}
Expand All @@ -165,9 +161,7 @@ func (d *Downloader) clean(directory string) error {

// clear all items in working directory
func (d *Downloader) clear() error {
cmd := exec.Command("rm", "-rf", UNTAR_DIRECTORY)
cmd.Dir = d.workdir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filepath change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

452b5d5

err := cmd.Run()
err := os.RemoveAll(UNTAR_DIRECTORY)
if err != nil {
return err
}
Expand Down