ADFA-4593: refresh cached help.db so schema changes take effect

The app copied assets/help.db to filesDir only when the app versionCode changed,
so reinstalling the same version kept a stale DB (missing the new 'lang' column ->
'no such column: T.lang'). Now: debug builds always re-copy on launch; release
builds re-copy when a bundled DB version constant (DB_ASSET_VERSION) changes.
Copy happens at most once per process.

Author: AppDevForAll

controller/app/src/main/java/org/iiab/controller/help/TooltipManager.java

@@ -15,7 +15,7 @@
 
 import android.content.Context;
 import android.content.SharedPreferences;
-import android.content.pm.PackageInfo;
+import android.content.pm.ApplicationInfo;
 import android.content.res.Configuration;
 import android.database.Cursor;
 import android.database.sqlite.SQLiteDatabase;
@@ -37,7 +37,6 @@
 import android.widget.TextView;
 
 import androidx.appcompat.app.AlertDialog;
-import androidx.core.content.pm.PackageInfoCompat;
 
 import org.iiab.controller.R;
 
@@ -64,6 +63,8 @@ public final class TooltipManager {
     private static final ExecutorService IO = Executors.newSingleThreadExecutor();
     private static final Handler MAIN = new Handler(Looper.getMainLooper());
     private static PopupWindow activePopup;
+    private static final int DB_ASSET_VERSION = 2;
+    private static volatile boolean copiedThisProcess = false;
 
     private TooltipManager() {}
 
@@ -174,16 +175,18 @@ private static SQLiteDatabase openDatabase(Context context) {
     private static synchronized File ensureDatabase(Context context) {
         File out = new File(context.getFilesDir(), LOCAL_DB);
         try {
-            long appVersion = -1;
-            try {
-                PackageInfo pi = context.getPackageManager()
-                        .getPackageInfo(context.getPackageName(), 0);
-                appVersion = PackageInfoCompat.getLongVersionCode(pi);
-            } catch (Exception ignored) {}
+            if (copiedThisProcess && out.exists()) return out;
 
+            boolean debuggable = (context.getApplicationInfo().flags
+                    & ApplicationInfo.FLAG_DEBUGGABLE) != 0;
             SharedPreferences sp = context.getSharedPreferences("help_db", Context.MODE_PRIVATE);
-            long copied = sp.getLong("version", -1);
-            if (out.exists() && copied == appVersion) return out;
+            int stored = sp.getInt("db_asset_version", -1);
+            // Debug builds always refresh (content changes without a version bump);
+            // release builds refresh only when the bundled DB version changes.
+            if (out.exists() && !debuggable && stored == DB_ASSET_VERSION) {
+                copiedThisProcess = true;
+                return out;
+            }
 
             try (InputStream in = context.getAssets().open(ASSET_DB);
                  OutputStream os = new FileOutputStream(out)) {
@@ -193,7 +196,8 @@ private static synchronized File ensureDatabase(Context context) {
                     os.write(buf, 0, n);
                 }
             }
-            sp.edit().putLong("version", appVersion).apply();
+            sp.edit().putInt("db_asset_version", DB_ASSET_VERSION).apply();
+            copiedThisProcess = true;
             return out;
         } catch (Exception e) {
             Log.e(TAG, "ensureDatabase failed: " + e.getMessage());