Skip to content

Commit 87aff5d

Browse files
ADFA-4986: document the mid-install safety-timeout trade-off (review note)
1 parent d9f1d39 commit 87aff5d

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

‎controller/app/src/main/java/org/iiab/controller/redesign/LibraryActivity.java‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,13 @@ public android.graphics.Typeface fetchFont(String fontFamily) {
301301
}
302302
}, AUTOSTART_DELAY_MS);
303303
}
304-
// Safety: never trap the user behind the gate — but ADFA-4986: don't lift it mid-install
305-
// (a live download/extraction drives its own dismissal on SUCCESS via the terminal path).
304+
// Safety: never trap the user behind the gate — but ADFA-4986: don't lift it mid-install.
305+
// Deliberate trade-off: while an install is live there is intentionally NO safety-timeout
306+
// dismissal here; the gate is lifted only when the install reaches a terminal state (the
307+
// InstallProgressRepository observer: SUCCESS starts the server then opens, FAILED opens
308+
// to the offline library) — the same contract as the first-run `if (installing)` branch,
309+
// which also has no safety net. A genuinely hung install (no terminal) is a separate
310+
// concern owned by the installer, not something to paper over by opening a broken system.
306311
main.postDelayed(() -> {
307312
if (!gateDismissed && !installing) {
308313
onServerReady();

0 commit comments

Comments
 (0)